Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator: check datasetId in visualizations table exists in measurem… #255

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 19, 2024

…ents table

Closes #229

@dweindl dweindl requested a review from m-philipps as a code owner April 19, 2024 08:23
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.27%. Comparing base (f32feed) to head (eb3143b).

Files Patch % Lines
petab/visualize/lint.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #255      +/-   ##
===========================================
+ Coverage    76.25%   76.27%   +0.02%     
===========================================
  Files           34       34              
  Lines         3218     3225       +7     
  Branches       780      783       +3     
===========================================
+ Hits          2454     2460       +6     
  Misses         560      560              
- Partials       204      205       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 4cd02ef into develop Apr 19, 2024
7 checks passed
@dweindl dweindl deleted the fix_229_validate_vis_dset branch April 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants