Typehint states it is optional, but no default value is provided. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweindl
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Typehint states it is optional, but no default value is provided
x: Optional[pd.DataFrame] does not imply that it's an optional argument (i.e. should have a default value). It just means that None is a valid value. The naming is very unfortunate. But fine to default to None in this specific case.
True perhaps the naming is just unfortunate. Also saw no problem in None as default value. Thanks, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add None as default value, due to optionality.