Skip to content

feat: show Keyverse identity fail-closed (v0.76.0) - #221

Open
seonghobae wants to merge 1 commit into
mainfrom
feat/keyverse-idp-fail-closed-v0760
Open

feat: show Keyverse identity fail-closed (v0.76.0)#221
seonghobae wants to merge 1 commit into
mainfrom
feat/keyverse-idp-fail-closed-v0760

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Buyer impact

After login, Identity sits above Calendar. When Keyverse is unconfigured or GET /healthz is down, Demo Analyst sees Identity · Keyverse not available. When the published {status: ok} envelope is accepted, the panel names readiness only. Never invent an issuer, account, or token. Demo login stays on the synthetic Keycloak realm.

  • KeyverseClient default transport raises KeyverseNotAvailable.
  • build_keyverse_client(base_url=...) uses HttpKeyverseTransport, which GETs {base}/healthz through the http(s)-only client.
  • HTTP 4xx/5xx, timeout, network, file://, and an unknown envelope fail closed.
  • Extra healthz fields are dropped — never copied as an issuer or account.
  • GET /api/identity is post_read and returns unavailable + ready=false when the port is down.
  • Tests: default/empty-URL fail-closed, published ok accepted, unknown/non-ok envelope fail-closed, HTTP errors fail-closed, frontend unavailable/accepted (no invented login).
  • ADR 0025 + CHANGELOG 0.76.0 + ARCHITECTURE / AGENTS.

Exact head

7cf1a7bcdf867f5066364168014b99918a4bf5f1 on feat/keyverse-idp-fail-closed-v0760.

Base: main @ 7464abb (merged #211 leftover pairs).

Review gate

Not in this slice

Leftover pairs landed as #211. TEPP fail-closed HTTP is #214. naruon mailbox is #217. ThreadWeave conversations are #219. RankWeave rankings are #220. Storybook increment is #123/#192. Registering LineageWeave as a Keyverse relying party remains a later slice.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@seonghobae
seonghobae enabled auto-merge (squash) August 17, 2026 09:33
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e8fb3fc3-0b2a-4d00-84a2-2160597d7bca

📥 Commits

Reviewing files that changed from the base of the PR and between 8c020aa and 8a6c807.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (18)
  • .env.example
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.d/0.76.0-keyverse-identity-fail-closed.md
  • CHANGELOG.md
  • README.md
  • backend/app/config.py
  • backend/app/main.py
  • backend/tests/test_config.py
  • docs/adr/0025-keyverse-identity-fail-closed.md
  • frontend/package.json
  • frontend/src/App.test.tsx
  • frontend/src/App.tsx
  • frontend/src/api.ts
  • lineageweave/__init__.py
  • lineageweave/keyverse_client.py
  • pyproject.toml
  • tests/test_keyverse_client.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact head 7cf1a7b is waiting on independent current-head APPROVE. This COMMENT is not APPROVE and is not a merge. Do not self-approve. Do not invent an issuer, account, or token.

After login, Identity names keyverse_not_available when the port is
down and names readiness when Keyverse healthz returns status ok.
Never invent an issuer, account, or token. Demo login stays on
synthetic Keycloak. Independent exact-head APPROVE required.
Do not mix into #74 or #92.
@seonghobae
seonghobae force-pushed the feat/keyverse-idp-fail-closed-v0760 branch from 7cf1a7b to 8a6c807 Compare August 17, 2026 10:18

Copy link
Copy Markdown
Contributor Author

Rebased onto main@8c020aa (RankWeave v0.75.0). Version stays 0.76.0. Rankings and Identity both stay. Independent exact-head APPROVE still required. Do not mix into #74 or #92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant