Skip to content

feat: show RankWeave rankings fail-closed (v0.75.0) - #220

Merged
seonghobae merged 1 commit into
mainfrom
feat/rankweave-fusion-fail-closed-v0750
Aug 17, 2026
Merged

feat: show RankWeave rankings fail-closed (v0.75.0)#220
seonghobae merged 1 commit into
mainfrom
feat/rankweave-fusion-fail-closed-v0750

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Buyer impact

After login, Rankings sits above Calendar. When RankWeave is disabled or the library is missing, Demo Analyst sees Rankings · RankWeave not available. When the in-process library accepts visible posts, accepted hits are listed by title. Click opens that post. A hidden post is omitted from every channel. Never invent a fused score or a theta.

  • RankWeaveClient default transport raises RankWeaveNotAvailable.
  • build_rankweave_client(disabled=False) uses LibraryRankWeaveTransport, which imports weighted_reciprocal_rank_fuse inside the call (Cormack et al. 2009 η = 60; Samuel et al. 2025 unequal weights).
  • GET /api/rankings is post_read and returns unavailable + empty rankings when the port is down.
  • Tests: default/disabled/missing-library/fuse-raises fail-closed, accepted hits, hidden post omitted, lexical ranks quote first, unknown envelope fail-closed, invented id dropped, frontend unavailable/accepted click.
  • ADR 0024 + CHANGELOG 0.75.0 + ARCHITECTURE / AGENTS.

Exact head

e574dab on feat/rankweave-fusion-fail-closed-v0750.

Base: main @ 7464abb (merged #211 leftover pairs).

Review gate

Not in this slice

Leftover pairs landed as #211. TEPP fail-closed HTTP is #214. naruon mailbox is #217. ThreadWeave conversations are #219. Storybook increment is #123/#192. Keyverse IdP remains a later slice.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@seonghobae
seonghobae enabled auto-merge (squash) August 17, 2026 09:29
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2854664e-f51c-4262-9dd2-138f5bcb9d23

📥 Commits

Reviewing files that changed from the base of the PR and between 7464abb and e574dab.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (18)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.d/0.75.0-rankweave-fusion-fail-closed.md
  • CHANGELOG.md
  • README.md
  • backend/app/config.py
  • backend/app/main.py
  • backend/app/ranking_ingestion.py
  • backend/tests/test_config.py
  • docs/adr/0024-rankweave-fusion-fail-closed.md
  • frontend/package.json
  • frontend/src/App.test.tsx
  • frontend/src/App.tsx
  • frontend/src/api.ts
  • lineageweave/__init__.py
  • lineageweave/rankweave_client.py
  • pyproject.toml
  • tests/test_rankweave_client.py
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch feat/rankweave-fusion-fail-closed-v0750
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/rankweave-fusion-fail-closed-v0750

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot disabled auto-merge August 17, 2026 09:29
After login, Rankings names rankweave_not_available when the port is
down and lists accepted fused hits when RankWeave ranks visible posts.
A hidden post is omitted. Never invent a fused score or a theta.
Independent exact-head APPROVE required. Do not mix into #74 or #92.
@seonghobae
seonghobae enabled auto-merge (squash) August 17, 2026 09:30
@seonghobae
seonghobae force-pushed the feat/rankweave-fusion-fail-closed-v0750 branch from d141621 to e574dab Compare August 17, 2026 09:31
@seonghobae
seonghobae merged commit 8c020aa into main Aug 17, 2026
29 checks passed
cursor Bot pushed a commit that referenced this pull request Aug 17, 2026
Bring leftover post–criterion pairs (#211) and fail-closed Rankings
(#220) onto this branch without colliding with the protected ADR and
migration numbers already used here.

Renumber main's leftover-pair migration to 0026 and ADRs to 0028–0030.
Keep analysis-run create (0017), related-node walks (0018), seed period
report (0024), and role-responsibility agent type (0012). Rankings sit
above Calendar; leftover pairs sit above report members.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant