feat(ui): name next action on plural affiliation chips (v0.77.0) - #192
feat(ui): name next action on plural affiliation chips (v0.77.0)#192seonghobae wants to merge 1 commit into
Conversation
Related-node chips now distinguish a unique org, a known-plural set, and a missing affiliation. After make seed, walking from Ada West shows Priya Nair, multiple organizations (Counterparty) and tells the operator to read the Keyman list before continuing the walk. The chip never invents a Northridge Grid primary. Identity-rule tests live under tests/ so backend/tests stays live-stack only. No AGENTS.md rewrite. No new ADR-0015 number.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (21)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthrough관련 노드가 온톨로지 유형 대신 측면, 소속, 조직 수준, 게시물 제목을 표시합니다. 백엔드는 소속 모호성을 집계합니다. 프론트엔드는 접근성 이름과 노드별 탐색 동작을 제공합니다. Changes관련 노드 업무 문맥
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: 🟡 Moderate · up to This change improves plural affiliation-chip labeling and follow-up guidance, but the required PR checks are still incomplete, so the change is not ready to merge until those checks pass. Sequence Diagram(s)sequenceDiagram
participant Keyman 패널
participant knowledge_graph.py
participant App.tsx
participant RelatedNodeChip
Keyman 패널->>knowledge_graph.py: 관련 노드와 소속 정보 조회
knowledge_graph.py-->>App.tsx: 측면·소속·조직 수준 필드 반환
App.tsx->>RelatedNodeChip: 노드와 동작 전달
RelatedNodeChip-->>App.tsx: 선택 노드 반환
App.tsx-->>Keyman 패널: 게시물 열기 또는 사람·기업 탐색
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed against #92 / #123 / #181. This is the preferred main-line chip landing.
No product defect found. Independent last-push approval still required. Do not merge #92 or #181 instead. |
Buyer impact
After
make seed, walk from Ada West. The Priya chip saysPriya Nair, multiple organizations (Counterparty). That is not an invented Northridge Grid primary, and it is not a side-only chip that looks like Priya has no organization. The related panel then names the next action: read every organization in the Keyman list above (or extract Keymen if that list is empty), then click the chip to continue the walk.Walk from Demo Corp and you see
Ada West, Demo Corp (Our side)andDemo Corp (Company). Post chips show the title only.#92 review fix
Cursor requested the missing-vs-plural signal on #92 (
15de5d4is identity-only). This head is that signal plus the on-panel next action.entity_name; aliases collapse; distinct multiples stayaffiliation_ambiguous.affiliation_ambiguousstill shows the plural signal.tests/test_related_node_affiliation_ambiguity.py(no_FakeConnectioninbackend/tests/). Live-stack assertions stay inbackend/tests/test_api.pyand self-skip withoutmake up.Prefer this over
This PR does not rewrite AGENTS.md and does not steal ADR-0015 or
0012+migration numbers from #74. Do not merge the #150/#162 stack before #74.Test plan
uv run python -m pytest tests/test_related_node_affiliation_ambiguity.py tests/test_knowledge_graph.py tests/test_adaptive_orchestration_defaults.py tests/test_ontology.py— 34 passedcd frontend && pnpm run lint && pnpm run test && pnpm run build— oxlint clean, 53 passed, production build okSynthetic fixtures only.
person_affiliationremains N:N with no primary column and no interval columns.Summary by CodeRabbit
새 기능
문서
버그 수정