[ Xedra Evolved ] Salamander eruption mutable special

[Maleclypse]

Summary

Mods "Xedra Evolved: Salamander Eruption"

Purpose of change

Paraclesian starts need to have dungeons that allow them to gather the materials they need to mutate. This is the first of those. I've based it off of the mines to start once I've got it working I'll build separate finales for it.

Describe the solution

Mutable special, need help with mutable structure. I always mess up there.

Describe alternatives you've considered

Making much smaller eruptions. That would be intelligent. Maybe I could make some one tile micro intrusions.

Testing

In progress.

Additional context

[Maleclypse]

@John-Candlebury if you have a minute to make recommendations on the connections section? I always get so confused on mutables at this point. I think I've got the z-0 and z-1 connections complete. I need to get the z-0 to z.-1 connection working basically the ground floor to eruption entrance. Basically I'm removing the mine shaft layer and then I'm having difficulties there. I think once I'm past that I can rename all the mine overmaps to my salamander overmaps?

[github-actions]

Auto-requesting reviews from non-collaborators: @GuardianDll

[John-Candlebury]

If I understand your intentions here, I think you just want a simple connection type for both the 0 to +1 gap and another one for the 0 to -1 gap.
So in this case the vertical connections function just like the simple horizontal tunnel_to_tunnel connections

[Maleclypse]

So I'm getting these two errors on start now.

16:35:02.026 ERROR : C:\Users\colli\Documents\GitHub\Cataclysm-DDA\src\overmap.cpp:1524 [finalize] invalid join id tunnel_entrance_to_tunnels in overmap tunnel_entrance in overmap special Salamander eruption
16:35:07.623 ERROR : C:\Users\colli\Documents\GitHub\Cataclysm-DDA\src\overmap.cpp:1675 [finalize] phase of overmap special Salamander eruption specifies overmap salamander_eruption_entrance which is not defined for that special

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• Tezcatlipoca's blood
• salamagman
• salamagman battle axe
• salamagman battle axes
• salamagman champion
• salamagman champions
• salamagman hand axe
• salamagman hand axes
• salamagman warlord
• salamagman warlords
• salamagmans

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.