Skip to content

Conversation

@akharit
Copy link
Member

@akharit akharit commented Oct 30, 2018


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

  • Added retry for getting tokens
  • Added requests>=2.20 because of CVE 2018-18074
  • Fixed test parameters and updated test recordings

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.
    NA

akharit and others added 13 commits October 4, 2018 14:07
* Fix for test case failure by adding randomized file path

* Fix for empty folder upload issue

* Fix chunked downloader to make block size requests
Added readinto method.
* Json supported requests to fix msconcat issues with symbols in source files.

* Changed api-version to 2018-05-01 for all.
* Add retry to check_tokenn and auth function

* Added tests

* Fix test environment variables

* Upgrade requests minimum version because of CVE 2018-18074
* Updated test recordings
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 86.344% when pulling 2641a9a on dev into 4b203ee on master.

@akharit akharit merged commit f346c38 into master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants