Skip to content

Readinto method #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2018
Merged

Readinto method #246

merged 4 commits into from
Oct 15, 2018

Conversation

@akharit
Copy link
Member

@akharit akharit commented Oct 12, 2018

This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

Adds readinto function as requested in #232

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
    I'll update that after making a couple of merge and then merging dev to master.
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

akharit added 4 commits October 4, 2018 15:20
@akharit
Various bug fixes. (#243) (#244)
1f9fe18 
* Fix for test case failure by adding randomized file path

* Fix for empty folder upload issue

* Fix chunked downloader to make block size requests
@akharit
Added docstrings
bb04bb2
@akharit
Merge branch 'dev' into akharit-readinto
898745c
@akharit
Added tests
8e79a5f
@coveralls
Copy link

coveralls commented Oct 12, 2018

Coverage Status

Coverage increased (+0.04%) to 85.809% when pulling 8e79a5f on akharit-readinto into c80bc96 on dev.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 12, 2018

Coverage Status

Coverage increased (+0.04%) to 85.809% when pulling 8e79a5f on akharit-readinto into c80bc96 on dev.

@coveralls
Copy link

coveralls commented Oct 12, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 85.809% when pulling 8e79a5f on akharit-readinto into c80bc96 on dev.

@akharit akharit merged commit b7afbb7 into dev Oct 15, 2018
@akharit akharit deleted the akharit-readinto branch November 6, 2018 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahuldutta90 rahuldutta90 Awaiting requested review from rahuldutta90

1 more reviewer

@lewu-msft lewu-msft lewu-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akharit @coveralls @lewu-msft