Skip to content

Various bug fixes. #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 4, 2018
Merged

Various bug fixes. #243

merged 8 commits into from
Oct 4, 2018

Conversation

@akharit
Copy link
Member

@akharit akharit commented Sep 24, 2018

This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

@coveralls
Copy link

coveralls commented Sep 24, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 85.767% when pulling e6a3e6c on akharit-bug-fixes into d64d9d8 on dev.

lewu-msft
lewu-msft approved these changes Oct 4, 2018
View reviewed changes
Copy link

@lewu-msft lewu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akharit akharit merged commit c80bc96 into dev Oct 4, 2018
akharit added a commit that referenced this pull request Oct 4, 2018
@akharit
Various bug fixes. (#243) (#244)
1f9fe18 
* Fix for test case failure by adding randomized file path

* Fix for empty folder upload issue

* Fix chunked downloader to make block size requests
@akharit akharit deleted the akharit-bug-fixes branch October 4, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rahuldutta90 rahuldutta90 rahuldutta90 approved these changes

@lewu-msft lewu-msft lewu-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akharit @coveralls @rahuldutta90 @lewu-msft