Retry for authentication(getting tokens) #251

akharit · 2018-10-23T19:53:44Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

Add retry for auth method in lib.py that gets the token for the first time. Also moved check_token under the retry code block in call method so we don't fail a call because of transient issues in token refresh.

General Guidelines

The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
Will be done when merge to master
The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
[] Links to associated bugs, if any, are in the description.
NA

coveralls · 2018-10-24T00:55:47Z

Coverage increased (+0.5%) to 86.315% when pulling ac65195 on authentication-retry into dc7d053 on dev.

coveralls · 2018-10-24T00:55:48Z

Coverage increased (+0.5%) to 86.315% when pulling ac65195 on authentication-retry into dc7d053 on dev.

coveralls · 2018-10-24T00:55:48Z

Coverage increased (+0.5%) to 86.344% when pulling b8b6178 on authentication-retry into dc7d053 on dev.

lewu-msft

some minor comments for now

azure/datalake/store/lib.py

lewu-msft · 2018-10-25T22:18:11Z

tests/test_mock.py

+                  body=body_discovery,
+                  status=200)
+
+        responses.add(responses.POST, mock_url, body=r'{"error":"' + error_string + r'","error_description":"0","error_codes":[0],"timestamp":"0","trace_id":"0","correlation_id":"0"}'


minor: refactor this format a little bit?

lewu-msft · 2018-10-25T22:18:41Z

azure/datalake/store/retry.py

+                            Response = namedtuple("Response", list(response.keys()) + ['status_code'])
+                            values = list(response.values()) + [int(http_code.group(1))]
+                            response = Response(
+                                *values)  # Construct response object with adal exception response and http code


minor: refactor this format a little bit?

lewu-msft

LGTM
let Rahul to double check

…nt with PEP

azure/datalake/store/core.py

* Retry for authentication(getting tokens) (#251) * Fix test environment variables * Upgrade requests minimum version because of CVE 2018-18074 * Test recordings update (#250) * Updated history.rst and version number

akharit added 4 commits October 23, 2018 11:58

Add guard in retry agains invalid respone input

5277c4e

Add retry to check_tokenn and auth function

c8a83fb

Added tests

54927ef

Removed ssl verify set to false

ba42947

akharit requested review from lewu-msft and rahuldutta90 October 23, 2018 19:53

akharit added 6 commits October 23, 2018 13:25

Reverting authority

9a4adeb

Tests fix

d96cc13

Refactored to a decorator

47de1b1

Response == None guard

1c9a8a5

Fix test environment variables

7ce8f19

400 test fix

ac65195

Some formatting changes

b7af53b

lewu-msft suggested changes Oct 25, 2018

View reviewed changes