Skip to content

Test recordings update #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 30, 2018
Merged

Test recordings update #250

merged 6 commits into from
Oct 30, 2018

Conversation

@akharit
Copy link
Member

@akharit akharit commented Oct 16, 2018 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

Test recordings are in need of an update, especially after the API change.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
    NA
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.
    NA

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 86.344% when pulling af67062 on akharit-test-recordings into aff7d1a on dev.

@akharit akharit merged commit 8f77ce1 into dev Oct 30, 2018
akharit added a commit that referenced this pull request Oct 31, 2018
@akharit
Merge to master for release 0.0.35 (#253)
f346c38 
* Retry for authentication(getting tokens) (#251)

* Fix test environment variables

* Upgrade requests minimum version because of CVE 2018-18074

* Test recordings update (#250)

* Updated history.rst and version number
@akharit akharit deleted the akharit-test-recordings branch November 6, 2018 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akharit @coveralls