Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Badge: Remove unused component files" #78941

Conversation

valterlorran
Copy link
Contributor

Reverts #78814

sirbrillig and others added 30 commits June 29, 2023 11:19
Co-authored-by: Omar Alshaker <omar@omaralshaker.com>
Logout users upon clicking on "Sign in as a different user" button, so their other WPCOM account wouldn't interfere.
* Update Congrats page for multi plugins (#78716)

Co-authored-by: Paulo Trentin <paulo@paulotrentin.com.br>
Co-authored-by: Gabriel Demichelis <gabrieldemichelis@gmail.com>
* Edge Cache: Disable toggle if the site isn't public

* Switch to "Review"
* Domains: refresh Manage all domains button

* Use domains slug instead of upgrades
* Fonts two-column layout

* Colors layout fixes

* Fixes for wide breakpoint

* Fixes for default font

* Revert nesting selector title

* Fix alignment for the no-title case

* Clean up the default font pairing and add comments
* Add Manage all domains link to Quick links

* Add Tracks event

* Add domains links to Quick Links for Devs

* Don't add "Add a domain" link for staging sites

---------

Co-authored-by: Philip Jackson <p-jackson@live.com>
This change is to work in conjunction with D110794-code. Rather than
using the environment flags, it checks the active features for the site,
allowing us to enable the feature on a per site basis.
)

* change default buckets for cookie banner

* update failing tests
* Revert "Revert "Add Jetpack connect screen loading screens and minor UI update (#78665)" (#78783)"

This reverts commit e91873d.

* Fix wrong this.isWooCoreProfiler check
* Reader: Create read feed search query hook

* Clean-up and add tests.

* Rename SiteSubscriptionsPortal.External back to SiteSubscriptionsPortal.Subscriptions

* Clean up the usage of SubscriptionManagerContextProvider

* Add @automattic/calypso-analytics dev dependency to data-stores

* Update yarn.lock

* Make @automattic/calypso-analytics a dependency

* Apply PR suggestions

* Add yarn.lock

* Add calypso-analytics entry into tsconfig
* Switch default start-writing theme to poema from livro

* Switched livro to hey theme on start-writing flow

---------

Co-authored-by: Paulo Trentin <paulo@paulotrentin.com.br>
* Extract empty state component

* Render empty state if no domains at all

* Scope empty state to All Domains

* Remove icon from CTA

* Rewrite CTA targets
* Replace seach component with one from sites page

to satisfy new design.

* Allow search bar to stretch

* Fix breaking by "#" as a search query

* Adjust search bar font properties

* Refactor search bar border radius for post/campaign

* Filter posts and campaigns before actual usage

* Fix the height of the search bar

* Use BlazablePost type for post items

* Fix outdated BlazePress import
* Show full TOS in checkout for domain transfers

* Convert CheckoutTerms to TS
#78815)

* Fixes the Blaze credits for atomic sites using the Blaze Dashboad app

* Fixes a problem with a config variable in the app
* My Sites: Remove manage domains from site selector

* My Sites: Remove manage domain click tracking
* Add tracks to the Blaze Dashboard app

* Fixes a typo in a comment
* Reader: Update sidebar to use ReaderAvatar component

* add hover style and increase size of icon

* lookup site/feed to get site icon

* only look up site/feed if no site icon found in follow
* Update SiteStream to functional component
* Adds sidebar to site stream
* Reader: update Feed/Site stream header and sidebar  (#78853)
* Sending hotjarSiteSettings to BlazePress.render call

* Test added
@valterlorran valterlorran requested a review from a team July 4, 2023 14:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valterlorran valterlorran force-pushed the revert-78814-remove/outdated-badge-files branch from e80633e to 8b75da7 Compare July 4, 2023 14:13
@valterlorran valterlorran requested review from a team and worldomonation as code owners July 4, 2023 14:13
@valterlorran valterlorran requested a review from a team July 4, 2023 14:13
@valterlorran valterlorran requested review from a team as code owners July 4, 2023 14:13
@valterlorran valterlorran requested review from a team and aneeshd16 July 4, 2023 14:13
@matticbot
Copy link
Contributor

matticbot commented Jul 4, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~28 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions          +11 B  (+0.0%)      +17 B  (+0.0%)
entry-stepper                +11 B  (+0.0%)      +27 B  (+0.0%)
entry-main                   +11 B  (+0.0%)      +18 B  (+0.0%)
entry-login                  +11 B  (+0.0%)      +17 B  (+0.0%)
entry-domains-landing        +11 B  (+0.0%)      +17 B  (+0.0%)
entry-browsehappy            +11 B  (+0.0%)      +17 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~830 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
plugins                                  +98 B  (+0.0%)     +107 B  (+0.0%)
jetpack-cloud-plugin-management          +84 B  (+0.0%)      +96 B  (+0.0%)
site-setup-flow                          +70 B  (+0.0%)     +116 B  (+0.0%)
scan                                     +70 B  (+0.0%)      +40 B  (+0.0%)
import-hosted-site-flow                  +70 B  (+0.0%)     +116 B  (+0.0%)
import-flow                              +70 B  (+0.0%)     +116 B  (+0.0%)
backup                                   +70 B  (+0.0%)      +38 B  (+0.0%)
update-design-flow                       +56 B  (+0.0%)      +19 B  (+0.0%)
tailored-ecommerce-flow                  +56 B  (+0.0%)       -8 B  (-0.0%)
purchases                                +56 B  (+0.0%)      +93 B  (+0.0%)
jetpack-cloud-partner-portal             +56 B  (+0.0%)       -1 B  (-0.0%)
jetpack-cloud-agency-dashboard           +56 B  (+0.0%)       -1 B  (-0.0%)
hosting                                  +56 B  (+0.0%)     +112 B  (+0.1%)
earn                                     +56 B  (+0.0%)      +89 B  (+0.1%)
copy-site-flow                           +56 B  (+0.0%)       -5 B  (-0.0%)
checkout                                 +56 B  (+0.0%)     +100 B  (+0.0%)
domains                                  +50 B  (+0.0%)      +87 B  (+0.0%)
themes                                   +42 B  (+0.0%)     +109 B  (+0.0%)
theme                                    +42 B  (+0.0%)     +108 B  (+0.1%)
site-purchases                           +42 B  (+0.0%)       -5 B  (-0.0%)
settings-performance                     +42 B  (+0.0%)     +104 B  (+0.1%)
settings-jetpack                         +42 B  (+0.0%)      +25 B  (+0.0%)
sensei-flow                              +42 B  (+0.0%)       +6 B  (+0.0%)
podcasts-flow                            +42 B  (+0.0%)       -1 B  (-0.0%)
migrate                                  +42 B  (+0.0%)     +105 B  (+0.1%)
media                                    +42 B  (+0.0%)       -4 B  (-0.0%)
marketplace                              +42 B  (+0.0%)      +11 B  (+0.0%)
marketing                                +42 B  (+0.0%)      +68 B  (+0.0%)
jetpack-search                           +42 B  (+0.0%)      +35 B  (+0.0%)
jetpack-cloud-settings                   +42 B  (+0.0%)      +25 B  (+0.0%)
write-flow                               -34 B  (-0.0%)      -56 B  (-0.0%)
home                                     -34 B  (-0.0%)      +84 B  (+0.0%)
free-flow                                -34 B  (-0.0%)      -56 B  (-0.0%)
build-flow                               -34 B  (-0.0%)      -54 B  (-0.0%)
woocommerce-installation                 +28 B  (+0.0%)      +22 B  (+0.0%)
woocommerce                              +28 B  (+0.0%)      +16 B  (+0.0%)
stats                                    +28 B  (+0.0%)      +58 B  (+0.0%)
site-blocks                              +28 B  (+0.0%)      +99 B  (+0.0%)
settings-writing                         +28 B  (+0.0%)       -8 B  (-0.0%)
settings-security                        +28 B  (+0.0%)      +23 B  (+0.0%)
settings                                 +28 B  (+0.0%)       -7 B  (-0.0%)
security                                 +28 B  (+0.0%)      +99 B  (+0.0%)
promote-post                             +28 B  (+0.0%)      +68 B  (+0.0%)
privacy                                  +28 B  (+0.0%)      +99 B  (+0.1%)
posts-custom                             +28 B  (+0.0%)     +163 B  (+0.1%)
posts                                    +28 B  (+0.0%)     +163 B  (+0.1%)
plans                                    +28 B  (+0.0%)     +109 B  (+0.0%)
people                                   +28 B  (+0.0%)      +74 B  (+0.0%)
pattern-assembler-step                   +28 B  (+0.0%)       +3 B  (+0.0%)
notification-settings                    +28 B  (+0.0%)      +99 B  (+0.0%)
me                                       +28 B  (+0.0%)      +99 B  (+0.1%)
jetpack-social                           +28 B  (+0.0%)      +67 B  (+0.1%)
jetpack-connect                          +28 B  (+0.0%)      +31 B  (+0.0%)
jetpack-cloud-pricing                    +28 B  (+0.0%)      +13 B  (+0.0%)
jetpack-cloud-features-comparison        +28 B  (+0.0%)      +14 B  (+0.0%)
help                                     +28 B  (+0.0%)      +99 B  (+0.0%)
devdocs                                  +28 B  (+0.0%)      +22 B  (+0.0%)
add-ons                                  +28 B  (+0.0%)      +15 B  (+0.0%)
activity                                 +28 B  (+0.0%)      +37 B  (+0.0%)
account-close                            +28 B  (+0.0%)      +99 B  (+0.1%)
account                                  +28 B  (+0.0%)      +99 B  (+0.0%)
email                                    +22 B  (+0.0%)      +32 B  (+0.0%)
videopress-flow                          -20 B  (-0.0%)      -54 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~323 bytes added 📈 [gzipped])

name                                                     parsed_size           gzip_size
async-load-design-playground                                  -593 B  (-0.0%)     -110 B  (-0.0%)
async-load-signup-steps-emails                                -559 B  (-0.9%)      -92 B  (-0.5%)
async-load-design                                             -156 B  (-0.0%)       -3 B  (-0.0%)
async-load-signup-steps-domains                                +56 B  (+0.0%)     +102 B  (+0.1%)
async-load-calypso-reader-sidebar                              +42 B  (+0.1%)      +84 B  (+0.4%)
async-load-calypso-post-editor-editor-media-modal              +42 B  (+0.0%)       +1 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                     +42 B  (+0.0%)     +103 B  (+0.0%)
async-load-calypso-components-jetpack-sidebar                  +42 B  (+0.0%)       +8 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                +42 B  (+0.0%)     +103 B  (+0.0%)
async-load-signup-steps-plans-theme-preselected                +28 B  (+0.0%)     +107 B  (+0.2%)
async-load-signup-steps-plans-pm                               +28 B  (+0.0%)      +43 B  (+0.1%)
async-load-signup-steps-plans-atomic-store                     +28 B  (+0.0%)       +3 B  (+0.0%)
async-load-signup-steps-plans                                  +28 B  (+0.0%)     +107 B  (+0.2%)
async-load-signup-steps-add-ons                                +28 B  (+0.0%)      +20 B  (+0.1%)
async-load-design-blocks                                       +28 B  (+0.0%)       +2 B  (+0.0%)
async-load-calypso-my-sites-sidebar                            +28 B  (+0.0%)     +128 B  (+0.4%)
async-load-calypso-my-sites-plan-features-2023-grid            +28 B  (+0.0%)      +25 B  (+0.1%)
async-load-calypso-components-web-preview-component            +28 B  (+0.0%)      -17 B  (-0.0%)
async-load-calypso-blocks-jitm-templates-sidebar-banner        +28 B  (+0.1%)      +12 B  (+0.2%)
async-load-calypso-blocks-jitm-templates-notice                +28 B  (+0.1%)      +11 B  (+0.2%)
async-load-calypso-blocks-jitm-templates-default               +28 B  (+0.1%)      +15 B  (+0.2%)
async-load-calypso-post-editor-media-modal                     +14 B  (+0.0%)       +4 B  (+0.0%)
async-load-calypso-my-sites-current-site-notice                +14 B  (+0.0%)       -8 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 4, 2023
@valterlorran valterlorran deleted the revert-78814-remove/outdated-badge-files branch July 4, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.