Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: Show full "renewal" TOS for domain transfers #78808

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

sirbrillig
Copy link
Member

@sirbrillig sirbrillig commented Jun 29, 2023

Proposed Changes

Checkout displays a Terms of Service at the bottom of the page that includes the wording You agree to our Terms of Service and authorize your payment method to be charged on a recurring basis until you cancel. This TOS is only displayed for recurring purchases and not for one-time purchases. For one-time purchases there's a different line item that just reads You agree to our Terms of Service.

However, Domain Transfer products are special. Even though they are one-time purchases, they result in a Domain Registration product being create (with the same price as the Transfer costs at checkout). So in a way they are actually a Domain Registration and should have the full TOS for renewable products.

This PR updates the TOS to show the "recurring" text for domain transfers.

Inspired by this Slack thread: p1687542902188289-slack-C05CT832K2T

Testing Instructions

  • Add a domain transfer to your cart. It's not clear to me how to do this. 🤔
  • Complete each step to reach the bottom of checkout. Verify that you see the TOS with the recurring basis text.

@sirbrillig sirbrillig requested a review from a team as a code owner June 29, 2023 17:15
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 29, 2023
@sirbrillig sirbrillig self-assigned this Jun 29, 2023
</div>

<TermsOfService
hasRenewableSubscription={ hasRenewableSubscription( cart ) || hasDomainTransfer }
Copy link
Member Author

@sirbrillig sirbrillig Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to tell from this diff but this line (and the declaration of hasDomainTransfer) is the only change.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~7 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout        +48 B  (+0.0%)       +7 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~8 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             +48 B  (+0.0%)       +8 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal        +48 B  (+0.0%)       +8 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sirbrillig sirbrillig merged commit 6ab73a6 into trunk Jun 30, 2023
@sirbrillig sirbrillig deleted the update/full-tos-for-domain-transfer branch June 30, 2023 15:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants