-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: Show full "renewal" TOS for domain transfers #78808
Conversation
</div> | ||
|
||
<TermsOfService | ||
hasRenewableSubscription={ hasRenewableSubscription( cart ) || hasDomainTransfer } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to tell from this diff but this line (and the declaration of hasDomainTransfer
) is the only change.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~7 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~8 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed Changes
Checkout displays a Terms of Service at the bottom of the page that includes the wording
You agree to our Terms of Service and authorize your payment method to be charged on a recurring basis until you cancel
. This TOS is only displayed for recurring purchases and not for one-time purchases. For one-time purchases there's a different line item that just readsYou agree to our Terms of Service
.However, Domain Transfer products are special. Even though they are one-time purchases, they result in a Domain Registration product being create (with the same price as the Transfer costs at checkout). So in a way they are actually a Domain Registration and should have the full TOS for renewable products.
This PR updates the TOS to show the "recurring" text for domain transfers.
Inspired by this Slack thread: p1687542902188289-slack-C05CT832K2T
Testing Instructions
recurring basis
text.