Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting onboarding: preserve hosting flow even for already existing users #78861

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

zaguiini
Copy link
Contributor

Related to pet6gk-tn-p2#comment-464

Proposed Changes

We should show the empty sites dashboard CTAs when the user comes from /start/hosting, even if they already have sites. Not doing so breaks continuity.

Testing Instructions

On your existing WPCOM account with sites, browse /start/hosting and continue.

You should be redirected to /sites and see the centralized CTAs asking whether you'd like to create or import a site (instead of the sites list):

image

"Migrate a site" should point to /setup/import-hosted-site?source=sites-dashboard&hosting-flow=true.

Also verify that ref=calypso-nosites is NOT added as a query parameter if your account already has a site.

@zaguiini zaguiini added [Type] Bug When a feature is broken and / or not performing as intended Hosting onboarding labels Jun 30, 2023
@zaguiini zaguiini requested a review from a team June 30, 2023 19:50
@zaguiini zaguiini self-assigned this Jun 30, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 30, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~23 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
sites-dashboard       +123 B  (+0.0%)      +23 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@zaguiini zaguiini merged commit 78b8c25 into trunk Jun 30, 2023
@zaguiini zaguiini deleted the hosting/preserve-flow-even-if-non-dev branch June 30, 2023 19:58
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 30, 2023
@a8ci18n
Copy link

a8ci18n commented Jun 30, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8072700

Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jul 7, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hosting onboarding [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants