Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Add empty state to All Domains page #78841

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Jun 30, 2023

Closes https://github.com/Automattic/dotcom-forge/issues/2869.

Proposed Changes

Let's add an empty state component to /domains/manage when 'All domains' is selected and the user still has no domains.

image

Testing Instructions

  1. Create an account and two free sites;
  2. Browse /domains/manage.

You should see the empty state and the CTAs pointing to:

  • /domains/add;
  • /start/domain-transfer/domains.

@zaguiini zaguiini added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. Domains page emphasis i1 labels Jun 30, 2023
@zaguiini zaguiini requested review from jeyip, nuriapenya and a team June 30, 2023 10:41
@zaguiini zaguiini requested a review from a team as a code owner June 30, 2023 10:41
@zaguiini zaguiini self-assigned this Jun 30, 2023
@zaguiini zaguiini changed the title Domains/add empty state to all domains Domains: Add empty state to All Domains page Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023

@matticbot
Copy link
Contributor

matticbot commented Jun 30, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~240 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +824 B  (+0.0%)     +240 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link

@nuriapenya nuriapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty state was correctly implemented 👍🏽 but the "Add a domain" CTA currently links to the onboarding stepper /start/domain/domain-only. I believe it should stay in Calypso and use the /domains/add path, so users can return to the empty state if necessary when clicking "Back".

(cc: @saygunnyc for a double check here)

Screenshot 2023-06-30 at 13 40 50

Could we also remove the "+" icon from the CTA? As we are not displaying the dropdown anymore.

@zaguiini
Copy link
Contributor Author

Thanks @nuriapenya

If the "Add a domain" CTA should point to /domains/add, what should "Transfer a domain" do?

@saygunnyc
Copy link

what should "Transfer a domain" do?

Link to the current transfer flow, for now, you can see it by clicking on the card below on Domains LP. I believe there's a Calpyso version of this too. However, we should link to the new bulk domain transfer flow once launched. cc @alshakero

Screenshot 2023-06-29 at 10 04 27 AM

@zaguiini zaguiini requested a review from nuriapenya June 30, 2023 13:02
@zaguiini
Copy link
Contributor Author

Thanks @nuriapenya @saygunnyc this should be good to go now.

Copy link

@nuriapenya nuriapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👌🏽 everything looks good!

@zaguiini zaguiini merged commit 52cae38 into trunk Jun 30, 2023
@zaguiini zaguiini deleted the domains/add-empty-state-to-all-domains branch June 30, 2023 14:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 30, 2023
@a8ci18n
Copy link

a8ci18n commented Jun 30, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8072294

Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jul 7, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domains page emphasis i1 [Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants