-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains: Add empty state to All Domains page #78841
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~240 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The empty state was correctly implemented 👍🏽 but the "Add a domain" CTA currently links to the onboarding stepper /start/domain/domain-only
. I believe it should stay in Calypso and use the /domains/add
path, so users can return to the empty state if necessary when clicking "Back".
(cc: @saygunnyc for a double check here)
Could we also remove the "+" icon from the CTA? As we are not displaying the dropdown anymore.
Thanks @nuriapenya If the "Add a domain" CTA should point to |
Link to the current transfer flow, for now, you can see it by clicking on the card below on Domains LP. I believe there's a Calpyso version of this too. However, we should link to the new bulk domain transfer flow once launched. cc @alshakero |
Thanks @nuriapenya @saygunnyc this should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 👌🏽 everything looks good!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8072294 Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Closes https://github.com/Automattic/dotcom-forge/issues/2869.
Proposed Changes
Let's add an empty state component to
/domains/manage
when 'All domains' is selected and the user still has no domains.Testing Instructions
/domains/manage
.You should see the empty state and the CTAs pointing to:
/domains/add
;/start/domain-transfer/domains
.