Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: add ad-free experience to plan features #78574

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

aneeshd16
Copy link
Contributor

@aneeshd16 aneeshd16 commented Jun 23, 2023

Proposed Changes

  • Adds Ad-free experience to the feature list for the Personal plan on the checkout page. This change was meant to support this experiment( pbxNRc-2Hx-p2 ), but I feel it would benefit all users. This string is already translated and displayed in the plans grid.
image

Testing Instructions

  • Go to /checkout/<site slug>/personal-bundle where <site slug> is for a site on the free plan.
  • Confirm that the sidebar copy matches the screenshot.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@aneeshd16 aneeshd16 requested a review from a team June 23, 2023 10:26
@aneeshd16 aneeshd16 self-assigned this Jun 23, 2023
@aneeshd16 aneeshd16 requested a review from a team as a code owner June 23, 2023 10:26
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 23, 2023
@github-actions
Copy link

github-actions bot commented Jun 23, 2023

@aneeshd16 aneeshd16 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jun 23, 2023
@matticbot
Copy link
Contributor

matticbot commented Jun 23, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~12 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout        +32 B  (+0.0%)      +12 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~24 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             +32 B  (+0.0%)      +12 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal        +32 B  (+0.0%)      +12 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ddc22 ddc22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

P.S. Noticed the new checkout pages 😮
image

@aneeshd16 aneeshd16 force-pushed the add/checkout-personal-plan-features branch from a91c787 to 3f49e40 Compare June 23, 2023 12:46
@aneeshd16
Copy link
Contributor Author

P.S. Noticed the new checkout pages 😮

Same! Updated the PR with the new screenshot.

@matticbot
Copy link
Contributor

This PR modifies the release build for happy-blocks

To test your changes on WordPress.com, run install-plugin.sh happy-blocks add/checkout-personal-plan-features on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit add/checkout-personal-plan-features on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

Copy link
Collaborator

@JessBoctor JessBoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Screenshot 2023-06-27 at 13 29 01

@southp
Copy link
Contributor

southp commented Jun 30, 2023

I'm deploying this on @aneeshd16 's behalf in case the cold doesn't want to leave too soon :)

@southp southp merged commit a475fe2 into trunk Jun 30, 2023
@southp southp deleted the add/checkout-personal-plan-features branch June 30, 2023 02:04
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants