-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: add ad-free experience to plan features #78574
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~12 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~24 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a91c787
to
3f49e40
Compare
Same! Updated the PR with the new screenshot. |
This PR modifies the release build for happy-blocks To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-r7r-p2 |
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm deploying this on @aneeshd16 's behalf in case the cold doesn't want to leave too soon :) |
Proposed Changes
Ad-free experience
to the feature list for the Personal plan on the checkout page. This change was meant to support this experiment( pbxNRc-2Hx-p2 ), but I feel it would benefit all users. This string is already translated and displayed in the plans grid.Testing Instructions
/checkout/<site slug>/personal-bundle
where<site slug>
is for a site on the free plan.Pre-merge Checklist