ardupilotwaf: require minimum Python 3.8 #29490
Conversation
Python 3.12 is also available, but some packages are not.
Python 3.12 is also available, but some packages are not.
Makes the comment accurate. Python 3.8 is shipped in Ubuntu 20.04 focal by default so we can't move past until that goes EOL.
|
Why is it that we want to move forward with our minimum Python version? Doing so is likely to break a bunch of people's environments. |
|
I'm mostly proposing that we make the comment correct. If we want to keep 3.6 the minimum I suppose that's okay, but it has not seen a release in nearly four years and is nearly ten years old. We already tried the move a couple years ago (which is where the comment came from) but it had to be reverted because Ubuntu 18.04 was still on life support. Now that that's gone let's move. Making 3.8 the minimum also does make it easier to test. We e.g. can't CI test 3.6 compatibility anymore. |
|
Here are your previous thoughts: #23287 (comment) :) |
I don't understand why this is even a question Peter, like my mother always used to say, if "a bunch of people" jumped off a cliff would you follow them? |
| @@ -160,7 +160,7 @@ jobs: | |||
|
|
|||
| - uses: cygwin/cygwin-install-action@v5 | |||
| with: | |||
| packages: cygwin64 gcc-g++=10.2.0-1 ccache python37 python37-future python37-lxml python37-pip python37-setuptools python37-wheel git procps gettext | |||
| packages: cygwin64 gcc-g++=10.2.0-1 ccache python39 python39-future python39-lxml python39-pip python39-setuptools python39-wheel git procps gettext | |||
| @@ -548,7 +548,7 @@ def configure(cfg): | |||
|
|
|||
| # require python 3.8.x or later | |||
| cfg.load('python') | |||
| cfg.check_python_version(minver=(3,6,9)) | |||
| cfg.check_python_version(minver=(3,8,0)) | |||
There was a problem hiding this comment.
maybe if version_is_3.6, print big warning, sleep 5 seconds so user can see it
|
Incidentally, if you can show we're currently broken on 3.6.9 / 3.7.0 we could probably merge this with the 3.8.0 requirement. |
Makes the comment honest.
Requires upgrading Cygwin to Python 3.9. Python 3.12 is available but it doesn't have all our packages. I think we will have to modernize a bit more.