waf: require python 3.8.0 or later #23287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. The error is descriptive. 3.8 matches what's in Ubuntu 20.04. ryan@ryan-B650:~/Development/ardu_ws/src/ardupilot$ python2 waf configure
Setting top to : /home/ryan/Development/ardu_ws/src/ardupilot
Setting out to : /home/ryan/Development/ardu_ws/src/ardupilot/build
Autoconfiguration : enabled
Checking for program 'python' : /usr/bin/python2
Checking for python version >= 3.8.0 : 2.7.18
The python version is too old, expecting (3, 8, 0)
(complete log in /home/ryan/Development/ardu_ws/src/ardupilot/build/config.log) |
peterbarker
previously requested changes
Mar 22, 2023
| @@ -456,6 +456,10 @@ def configure(cfg): | |||
| if cfg.options.num_aux_imus > 0: | |||
| cfg.define('INS_AUX_INSTANCES', cfg.options.num_aux_imus) | |||
|
|
|||
| # require python 3.8.x or later | |||
| cfg.load('python') | |||
| cfg.check_python_version(minver=(3,8,0)) | |||
There was a problem hiding this comment.
Suggested change
| cfg.check_python_version(minver=(3,8,0)) | |
| cfg.check_python_version(minver=(3,6,0)) |
Let Ubuntu 18.04 continue to function
There was a problem hiding this comment.
yep, 3.8 don't bring much functionnality against 3.6, so using 3.6 is good
There was a problem hiding this comment.
yep, 3.8 don't bring much functionnality against 3.6, so using 3.6 is good
Discussed this with tridge.
bionic came with 3.8 and it's almost defunct.
Python 3.6 is also out of support.
tridge
dismissed
peterbarker’s stale review
discussed with Peter, agreed on 3.8
for 4.5.x we no longer support py2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for 4.5.x we no longer support py2