Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_VisualOdom: allow for visual odom position without yaw #23616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Apr 26, 2023

the quaternion passed in via handle_vision_position_estimate is only used by EKF3 for yaw, and the EKF code handles the case that the quaternion is NaN. We need to accept NaN attitude to allow for external navigation systems that only provide a position. This requires that users setup the yaw source as compass

the quaternion passed in via handle_vision_position_estimate is only
used by EKF3 for yaw, and the EKF code handles the case that the
quaternion is NaN. We need to accept NaN attitude to allow for
external navigation systems that only provide a position. This
requires that users setup the yaw source as compass
@tridge tridge added the EKF label Apr 26, 2023
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this seems OK but one potential issue and one thought:

  • Besides the EKF, the yaw is also used in the AP_VisualOdom's yaw and position alignment code so this should be checked to confirm it handles the NaN correctly. This is important for GPS/Non-GPS transitions where we may re-align the external nav source to match the GPS and compass (or whatever the yaw source is when ExtNav is not used)
  • If the EK3_SRCx_YAW param value is set to any value other than ExtNav (6?) then it shouldn't consume the yaw. It makes sense to have protections of course so that if an invalid yaw is passed in, it is not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants