GCS_MAVLink: routing: do not process our own packets locally #23240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returning true from this method means we will process the packets locally. If that message changes the vehicle state that could be bad.
|
This seems correct to me. |
rmackay9
approved these changes
Mar 17, 2023
khancyr
approved these changes
Mar 17, 2023
|
I think this change is the cause of this T265 failure reported by a user here in the forums: https://discuss.ardupilot.org/t/vision-positioning-using-t265-does-not-work/115679 I'm not saying we should revert this though. I think the user's T265 scripts are sending using the same system id and component id as the autopilot. |
92 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returning true from this method means we will process the packets locally.
If that message changes the vehicle state that could be bad.
This work sponsored by Harris Aerial.