AP_L1_Control:avoid big turn #19975
Closed
AP_L1_Control:avoid big turn #19975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing comma in `sim_vehicle.py`. Signed-off-by: mr.Shu <mr@shu.io>
Co-authored-by: Leonard Hall <leonardthall@gmail.com>
… fixed radius using turn rate guided command
Allows for all backends to be set to off by default.
this doesn't actually allow you to specify a default, despite the name and a couple of hwdefs trying to use it that way. This would have stopped being useful when we did the compass-prority-table stuff - or before.
this doesn't actually allow you to specify a default, despite the name and a couple of hwdefs trying to use it that way. This would have stopped being useful when we did the compass-prority-table stuff - or before.
this doesn't actually allow you to specify a default, despite the name and a couple of hwdefs trying to use it that way. This would have stopped being useful when we did the compass-prority-table stuff - or before.
this doesn't actually allow you to specify a default, despite the name and a couple of hwdefs trying to use it that way. This would have stopped being useful when we did the compass-prority-table stuff - or before.
velocity will stay at zero, which seems a reasonable thing to continue with in this function
|
@xianglunkai Thank you for this PR! Can you tell us more about the problem this is solving? Also, please rebase your branch. |
Closed
|
No, you still have not rebased it properly :( |
|
I've created an issue to cover what this PR is trying to do #20080. We might close this PR unless I can figure out how to rebase and then push overtop of it |
|
This PR needs to be rebased but it seems difficult for the submitter to do this and other developers (including me) can't access the branch listed in this PR so I'm going to close this PR and proceed with discussions on the issue. |
|
To me looks like the only commit is: ea22395 So just re-doing that single line change should be enough to get this fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.