This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Collection of recent PRs #1002
Closed
Collection of recent PRs #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f firebase-specific services
`getString` returns `null` if mapping does not exist for a key. (https://developer.android.com/reference/android/os/BaseBundle.html#getString(java.lang.String)) also `createNotificationChannel` (https://developer.android.com/reference/android/app/NotificationManager#createNotificationChannel(android.app.notificationchanne)) fails if channel name is an empty string.
On Android 6.0 (API level 23) and above in order to reduce battery consumption, the system enters in Doze mode whilethe device is unused for long periods of time. While on Doze mode the AlarmManager alarms dont execute exactly on the scheduled time, they are deferred to the next maintenance window. This cause the notifications to show after their scheduled time. This change adds a new attribute `allowWhileIdle` to allow the notification to be displayed while on doze
use `implementation` instead of `compile`
|
@mmccartney I think there are README changes needed for this as well... |
|
Thanks for this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I took the time to pull together and resolve conflicts in several PRs that have come in the last several months. They all look like good contributions to the project.