Improve the docs around specifying notification_color

[robwalkerco]

No description provided.

[krozett]

@robwalkerco Thanks! Although I also found that the file name given is wrong. It has to be android/app/src/main/res/values/colors.xml (note the 'main').

[robwalkerco]

@krozett I've checked. but I can't find anything that needs to be changed.
The correct filename is specified at https://github.com/zo0r/react-native-push-notification/pull/947/files#diff-04c6e90faac2675aa89e2176d2eec7d8R126

[krozett]

@robwalkerco I don't have any res subdirectory in android/app/src. Putting the colors.xml file where the docs suggest doesn't work for me, because that directory doesn't exist. Here's what my tree looks like:

android/app/src
└── main
   ├── AndroidManifest.xml
   ├── assets
   │  └── fonts
   ├── java
   └── res
      ├── mipmap-hdpi
      │  ├── ic_launcher.png
      │  └── ic_launcher_round.png
      ├── mipmap-mdpi
      │  ├── ic_launcher.png
      │  └── ic_launcher_round.png
      ├── mipmap-xhdpi
      │  ├── ic_launcher.png
      │  └── ic_launcher_round.png
      ├── mipmap-xxhdpi
      │  ├── ic_launcher.png
      │  └── ic_launcher_round.png
      ├── mipmap-xxxhdpi
      │  ├── ic_launcher.png
      │  └── ic_launcher_round.png
      └── values
         ├── strings.xml
         └── styles.xml

I just created a brand new fake project with react-native init. It created the exact same structure. Have you actually followed the documentation? If it works for you, maybe your RN is out of date.

[robwalkerco]

@krozett you’ve already got strings.xml and styles.xml in the folder where colors.xml needs to go. Just create the file there.

[krozett]

@robwalkerco That's exactly what I did. My issue is that the directory in the docs is wrong.

[robwalkerco]

Got you @krozett
Just updated it.

[krozett]

@robwalkerco Almost got it. The path should be android/app/src/main/res/values/colors.xml.

[robwalkerco]

Thanks @krozett

[mmccartney]

This is a helpful PR. I got tripped up on this when trying to implement colors. This fixes 2 issues with the documentation:

1. The path to the colors.xml was missing /main/
2. The meta-data reference had android: that shouldn't be there