This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Properly handle default values of metadata #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getString` returns `null` if mapping does not exist for a key. (https://developer.android.com/reference/android/os/BaseBundle.html#getString(java.lang.String)) also `createNotificationChannel` (https://developer.android.com/reference/android/app/NotificationManager#createNotificationChannel(android.app.notificationchanne)) fails if channel name is an empty string.
mmccartney
pushed a commit
to mmccartney/react-native-push-notification
that referenced
this pull request
Feb 15, 2019
Dallas62
approved these changes
Apr 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getStringreturnsnullif mapping does not exist for a key.(https://developer.android.com/reference/android/os/BaseBundle.html#getString(java.lang.String))
also
createNotificationChannel(https://developer.android.com/reference/android/app/NotificationManager#createNotificationChannel(android.app.notificationchanne))
fails if channel name is an empty string.
update
A bit more clearer explanation: w/o this fix if channel name is not provided through manifest the
getChannelNamewill returnnulland the following call tocreateNotificationChannel(https://github.com/zo0r/react-native-push-notification/blob/master/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotificationHelper.java#L577) will fail with exception, which will be swallowed here https://github.com/zo0r/react-native-push-notification/blob/master/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotificationHelper.java#L402 and entire flow will silently fail and no notifications will be shown to a user.