-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Allow command-line deployment for Android, and making FCM-first. #836
Conversation
…f firebase-specific services
@rhdeck are you using this in production? I assume this needs to be merged sometime soon anyways, since GCM is being deprecated in April... |
Yes, we use this in production, and it's been smooth enough that I haven't given it a thought in a few months. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is the most import PR for this project because it adds onNewToken()
and adopts the new FirebaseInstanceId
API. I also appreciate the attempt to automate the changes build.gradle
and AndroidManifest.xml
.
What a nice note. Glad to contribute! (And to soon move off my forked
version)
…On Fri, Feb 15, 2019 at 12:25 PM Mike McCartney ***@***.***> wrote:
***@***.**** approved this pull request.
IMO this is the most import PR for this project because it adds
onNewToken() and adopts the new FirebaseInstanceId API. I also appreciate
the attempt to automate the changes build.gradle and AndroidManifest.xml.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#836 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALov_7IwXIF0s4BLqYfUfilhoNQKVonGks5vNu1ngaJpZM4WFowJ>
.
|
Happy to help try to move things along. You have a conflict in I'm going to try creating a fork that merges this and other PRs in hopes to catch up on the backlog of changes. I really want to use this project for my app but if I can't get Android working in the next few days, I'm going to have to switch to something else... :-( |
Merged with current rev on my end, clearing the conflict. |
@rhdeck I think there are README changes needed for this as well before it can get merged... (and by changes I mean removing whole lot, since this simplifies things quite a bit) |
I concur with your point. Will check it out. |
…e code from dependencies
…ogle-services plugin
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
Address issue #827 and #828.
react-native-update-gradle
peer dependency to allow modern build processreact-native link
via prelink script and adding rnpm reference to package.jsonreact-native add-google-services
via plugin.js and rnpm reference in package.jsonUsage for testing:
Or, if you're like me and into native dev:
(Gradle synch isn't perfect in android studio right now. I sometimes have to "sync gradle with files" under the "File" menu to get things to build. This is not specific to the PR, but is general to using new gradle)