Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE310-based boards: transition from pinmux to pinctrl #44068

Merged
merged 7 commits into from
Mar 24, 2022
Merged

FE310-based boards: transition from pinmux to pinctrl #44068

merged 7 commits into from
Mar 24, 2022

Conversation

fkokosinski
Copy link
Member

This pull request contains the following changes as part of the effort in #39740:

  • introduction of the new pinctrl driver for FE310-based boards
  • modifications of the existing drivers used in FE310-based boards so that they use the pinctrl API
  • binding changes
  • removal of the obsolete pinmux counterpart

@github-actions github-actions bot added area: Boards area: Devicetree area: Devicetree Binding PR modifies or adds a Device Tree binding area: PWM Pulse Width Modulation area: SPI SPI bus labels Mar 22, 2022
gmarull
gmarull requested changes Mar 22, 2022
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I have a few comments (some non-blocking)

drivers/pinctrl/Kconfig.sifive Show resolved Hide resolved
boards/riscv/hifive1/hifive1-pinctrl.dtsi Show resolved Hide resolved
boards/riscv/hifive1/hifive1_defconfig Outdated Show resolved Hide resolved
dts/bindings/spi/sifive,spi0.yaml Outdated Show resolved Hide resolved
boards/riscv/hifive1/hifive1_defconfig Outdated Show resolved Hide resolved
@gmarull gmarull mentioned this pull request Mar 22, 2022
Closed
29 tasks
@fkokosinski fkokosinski force-pushed the 32799-pinmux-pinctrl-sifive branch 2 times, most recently from 395c6a8 to 555cf7d Compare March 22, 2022 13:36
@zephyrbot zephyrbot added area: Pinctrl area: UART Universal Asynchronous Receiver-Transmitter area: Pinmux area: RISCV RISCV Architecture (32-bit & 64-bit) labels Mar 22, 2022
@fkokosinski fkokosinski force-pushed the 32799-pinmux-pinctrl-sifive branch 2 times, most recently from 9cf1682 to a0de5bf Compare March 23, 2022 09:51
@fkokosinski fkokosinski force-pushed the 32799-pinmux-pinctrl-sifive branch 3 times, most recently from 61109a4 to 75df85d Compare March 23, 2022 13:45
gmarull
gmarull reviewed Mar 23, 2022
View reviewed changes
drivers/pinctrl/pinctrl_sifive.c Outdated Show resolved Hide resolved
drivers/serial/uart_sifive.c Show resolved Hide resolved
@fkokosinski
drivers: pinctrl: add SiFive pinctrl driver
357cdfc 
Add a pinctrl driver used in FE310-based boards.

Signed-off-by: Filip Kokosinski <fkokosinski@antmicro.com>
@fkokosinski
boards: hifive1: add pinctrl configuration for hifive1 board
edf2cfb 
Add pinctrl configuration for future use with the new pinctrl driver.

Signed-off-by: Filip Kokosinski <fkokosinski@antmicro.com>
@fkokosinski
boards: hifive1_revb: add pinctrl configuration for hifive1_revb board
b932ece 
Add pinctrl configuration for future use with the new pinctrl driver.

Signed-off-by: Filip Kokosinski <fkokosinski@antmicro.com>
@fkokosinski
boards: qemu_riscv32: add pinctrl configuration for qemu_riscv32_xip
d30415b 
Add pinctrl configuration for future use with the new pinctrl driver.

Signed-off-by: Filip Kokosinski <fkokosinski@antmicro.com>
@fkokosinski
boards: FE310-based boards: transition to pinctrl driver
f132c59 
This commit makes the transition from the pinmux driver to the pinctrl
driver. It also modifies UART, SPI and I2C drivers used in FE310-based
boards to use the new pinctrl API.

Signed-off-by: Filip Kokosinski <fkokosinski@antmicro.com>
@fkokosinski
drivers: pinmux: remove SiFive pinmux driver
ed0637c 
After transitioning to the new pinctrl driver, it is now obsolete.

Signed-off-by: Filip Kokosinski <fkokosinski@antmicro.com>
@fkokosinski
soc: riscv: sifive-freedom: fix SYS_CLOCK_HW_CYCLES_PER_SEC value
18f66f5 
This commit fixes the default value of SYS_CLOCK_HW_CYCLES_PER_SEC
option. The previous value of 32768 is not consistent with the
documentation of FE310 SoC. Only FE310-based boards rely on the default
value of this option; other boards from the Freedom series define it
themselves.

Signed-off-by: Filip Kokosinski <fkokosinski@antmicro.com>
@carlescufi carlescufi merged commit 8388bb7 into zephyrproject-rtos:main Mar 24, 2022
@tgorochowik tgorochowik deleted the 32799-pinmux-pinctrl-sifive branch March 24, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgorochowik tgorochowik tgorochowik approved these changes

@gmarull gmarull gmarull approved these changes

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@kgugala kgugala Awaiting requested review from kgugala kgugala is a code owner

@pgielda pgielda Awaiting requested review from pgielda pgielda is a code owner

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@anangl anangl Awaiting requested review from anangl

@dcpleung dcpleung Awaiting requested review from dcpleung

@edersondisouza edersondisouza Awaiting requested review from edersondisouza

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@katsuster katsuster Awaiting requested review from katsuster

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

@mgielda mgielda Awaiting requested review from mgielda

@mnkp mnkp Awaiting requested review from mnkp

Assignees

@kgugala kgugala

Labels
area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Pinctrl area: Pinmux area: PWM Pulse Width Modulation area: RISCV RISCV Architecture (32-bit & 64-bit) area: SPI SPI bus area: UART Universal Asynchronous Receiver-Transmitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fkokosinski @tgorochowik @gmarull @kgugala @carlescufi @zephyrbot