feat: Async zoxide

[lazysegtree]

Summary by CodeRabbit

• New Features

  • Zoxide modal now updates results asynchronously as you type.
  • New rendering with scores, truncated paths, and scroll indicators.
  • Improved navigation (JK/arrow keys), selection, and escape-to-close.
  • Modal resizes responsively with the window.

• Bug Fixes

  • Opening the Zoxide modal now reliably triggers its action.
  • Prevents stale search results from overwriting current input.
  • Ensures minimum modal dimensions for consistent display.
  • Suppresses unintended “z” hotkey while typing in inputs.
  • Resets cursor/render position correctly when results change.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Converts two globals to constants; propagates OpenZoxide command; integrates zoxide modal update flow via async UpdateMsg/GetQueryCmd; adds Render method and request-tracking; refactors test setup defaults; relocates and expands zoxide model/UI tests; adds UI navigation/render tests and helpers.

Changes

Cohort / File(s)	Summary of edits
Common constants src/internal/common/predefined_variable.go	Changed MinimumHeight and MinimumWidth from vars to consts.
Input handling and model wiring src/internal/key_function.go, src/internal/model.go	Propagate cmd from OpenZoxide; wire zoxideui.UpdateMsg into model update loop; share action/cmd handling for prompt/zoxide modals.
Test setup defaults src/internal/test_utils.go	Added DefaultTestModelWidth/DefaultTestModelHeight; centralized model test params via setModelParamsForTest.
Model-level tests reorg src/internal/model_test.go, src/internal/model_zoxide_test.go	Moved zoxide tests into dedicated file; added comprehensive modal open/search/navigate/resize/input tests with OS-conditional setup.
Zoxide UI core (logic/types/utils) src/internal/ui/zoxide/model.go, src/internal/ui/zoxide/type.go, src/internal/ui/zoxide/utils.go	Introduced async query via GetQueryCmd; added UpdateMsg type and Apply; added request counters; Open now returns tea.Cmd; added GetTextInputValue.
Zoxide UI rendering src/internal/ui/zoxide/render.go	New Render() method with result list, truncation, cursor highlight, and scroll indicators; nil-client fallback.
Zoxide UI tests and helpers src/internal/ui/zoxide/model_test.go, src/internal/ui/zoxide/navigation_test.go, src/internal/ui/zoxide/render_test.go, src/internal/ui/zoxide/test_helpers.go	Added tests for confirm, navigation, UpdateMsg apply, rendering, scroll indicators, and utilities; note: for i := range resultCount loop appears invalid in helper.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant App as Model
  participant ZUI as zoxide UI Model
  participant ZCli as zoxide Client

  User->>App: Hotkey (Open Zoxide)
  App->>ZUI: zoxideModal.Open()
  ZUI-->>App: tea.Cmd (GetQueryCmd(""))
  App->>App: Update loop runs cmd

  rect rgba(200,230,255,0.2)
    App->>ZCli: Query("") [async, reqID n]
    ZCli-->>App: Results or error
    App->>App: Emit zoxideui.UpdateMsg(reqID, query, results)
  end

  App->>ZUI: HandleUpdate(UpdateMsg)
  ZUI->>ZUI: Apply if query matches current input
  ZUI-->>App: NoAction/Action + optional cmd

  User->>ZUI: Type/filter, Navigate, Confirm
  ZUI-->>App: Actions (e.g., CDCurrentPanelAction)
  App->>App: Apply action (change directory)

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• feat: Zoxide integeration #1039 — Parallel zoxide integration adding UI package, modal handling, and tests.
• feat: Zoxide integ for query #1037 — Implements zoxide modal types, Open/HandleUpdate/Render, and model wiring.
• Prompt feature leftover items #804 — Overlaps in key handling and model update paths affected here.

Suggested labels

new feature, test related, refactoring

Suggested reviewers

• yorukot

Poem

I hop through dirs with zesty Z,
A whisker-twitch of query, whee!
Async breezes bring me trails,
Arrows point where carrot veils.
Scrolls and scores, a tidy view—
Thump-thump! New burrows, fresh and true.
(^._.^)/

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.13% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly and accurately describes the primary feature introduced by this changeset: asynchronous zoxide integration, aligning with the code changes that convert zoxide commands to async tea.Cmds and update related components.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[lazysegtree]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/internal/ui/zoxide/model.go (1)

47-86: Async zoxide results are dropped

GetQueryCmd emits UpdateMsg, but HandleUpdate never matches that type. The message falls through the default branch, where it’s ignored by textInput.Update, so query results are never applied and the modal stays stale. This breaks the async zoxide flow you just introduced.

Add a dedicated case UpdateMsg that invokes msg.Apply(m) before the other branches.

-	switch msg := msg.(type) {
-	case tea.KeyMsg:
+	switch msg := msg.(type) {
+	case UpdateMsg:
+		cmd = msg.Apply(m)
+	case tea.KeyMsg:

🧹 Nitpick comments (1)

src/internal/ui/zoxide/utils_test.go (1)

28-39: Restore global config after toggling ZoxideSupport.

This test flips common.Config.ZoxideSupport to true and leaves it that way, so later tests inherit the modified global and can fail depending on run order. Capture the original value and restore it via t.Cleanup (or defer) after the assertions.

 func TestOpenResetsState(t *testing.T) {
 	m := setupTestModelWithClient(t)
-	common.Config.ZoxideSupport = true
+	origSupport := common.Config.ZoxideSupport
+	common.Config.ZoxideSupport = true
+	t.Cleanup(func() {
+		common.Config.ZoxideSupport = origSupport
+	})

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 322c956 and c53014e.

📒 Files selected for processing (15)

• src/internal/common/predefined_variable.go (1 hunks)
• src/internal/key_function.go (1 hunks)
• src/internal/model.go (3 hunks)
• src/internal/model_test.go (0 hunks)
• src/internal/model_zoxide_test.go (1 hunks)
• src/internal/test_utils.go (1 hunks)
• src/internal/ui/zoxide/model.go (3 hunks)
• src/internal/ui/zoxide/model_test.go (1 hunks)
• src/internal/ui/zoxide/navigation_test.go (1 hunks)
• src/internal/ui/zoxide/render.go (1 hunks)
• src/internal/ui/zoxide/render_test.go (1 hunks)
• src/internal/ui/zoxide/test_helpers.go (1 hunks)
• src/internal/ui/zoxide/type.go (1 hunks)
• src/internal/ui/zoxide/utils.go (2 hunks)
• src/internal/ui/zoxide/utils_test.go (1 hunks)

💤 Files with no reviewable changes (1)

• src/internal/model_test.go

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/default_config.go:16-16
Timestamp: 2025-07-27T07:40:51.938Z
Learning: lazysegtree prefers simpler implementation approaches when the alternatives are significantly more complex, even if the alternatives might be architecturally cleaner, prioritizing maintainability and avoiding over-engineering.

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/default_config.go:16-16
Timestamp: 2025-07-27T07:40:51.938Z
Learning: lazysegtree prefers simpler implementation approaches when the alternatives are significantly more complex, even if the alternatives might be architecturally cleaner, prioritizing maintainability and avoiding over-engineering.

Learnt from: lazysegtree
PR: yorukot/superfile#969
File: src/internal/key_function.go:40-40
Timestamp: 2025-08-03T09:34:55.721Z
Learning: lazysegtree emphasizes proper dependency direction in software architecture, preferring that low-level components (like modal handlers) should not depend on high-level components (like the main model object). He also prioritizes performance considerations, noting that creating objects on every keypress in hot code paths like key handling is inefficient and should be avoided.

Learnt from: lazysegtree
PR: yorukot/superfile#1013
File: src/internal/model_render.go:329-341
Timestamp: 2025-08-29T14:11:21.380Z
Learning: lazysegtree prefers to defer help menu rendering optimizations and other technical debt improvements to separate GitHub issues when the current PR scope has grown too large, maintaining focus on the primary refactoring objectives while tracking performance improvements for future work.

Learnt from: lazysegtree
PR: yorukot/superfile#985
File: src/internal/model.go:0-0
Timestamp: 2025-08-11T01:49:30.040Z
Learning: lazysegtree prefers maintaining code correctness through proper design and invariants rather than adding defensive bounds checks at every slice access point, viewing such defensive programming as "duct taping" that can mask actual bugs instead of fixing them at their source.

Learnt from: lazysegtree
PR: yorukot/superfile#973
File: src/internal/ui/processbar/model_update.go:7-27
Timestamp: 2025-08-03T14:49:31.221Z
Learning: lazysegtree prefers to keep test-only code simple without adding production-level concerns like goroutine synchronization, cancellation contexts, or complex lifecycle management, even when such patterns might prevent potential issues, since the complexity isn't justified for test utilities.

Learnt from: lazysegtree
PR: yorukot/superfile#1044
File: src/internal/utils/file_utils.go:149-149
Timestamp: 2025-09-09T13:29:11.771Z
Learning: lazysegtree prefers to keep PR scope focused on the primary objectives and considers pre-existing technical debt issues as out of scope for migration/refactoring PRs, preferring to defer such issues to separate GitHub issues rather than expanding the current PR scope.

Learnt from: lazysegtree
PR: yorukot/superfile#950
File: src/internal/ui/metadata/README.md:7-7
Timestamp: 2025-07-24T03:46:29.516Z
Learning: lazysegtree prefers to defer comprehensive unit testing to separate PRs when the current PR has grown too large, maintaining focus on the primary refactoring objectives while tracking testing requirements in dedicated GitHub issues.

Learnt from: lazysegtree
PR: yorukot/superfile#967
File: src/internal/key_function.go:45-47
Timestamp: 2025-08-02T11:47:07.713Z
Learning: lazysegtree prefers to track technical debt and architectural improvements in dedicated GitHub issues when they are identified during PR reviews but are beyond the scope of the current PR, particularly for complex refactoring needs like input handling architecture that would require significant changes.

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/handle_file_operations.go:567-570
Timestamp: 2025-07-27T08:49:09.687Z
Learning: lazysegtree prefers to defer technical debt issues like model mutation concerns to later PRs when the current PR has already grown too large, maintaining focus on the primary objectives while acknowledging the need to track such issues for future work.

📚 Learning: 2025-08-24T03:24:50.857Z

Learnt from: lazysegtree
PR: yorukot/superfile#1013
File: src/internal/utils/file_utils.go:18-21
Timestamp: 2025-08-24T03:24:50.857Z
Learning: The superfile project uses github.com/charmbracelet/x/ansi as the standardized ANSI package and deprecates github.com/charmbracelet/x/exp/term/ansi to avoid binary bloat and potential incompatibilities.

Applied to files:

• src/internal/model.go

📚 Learning: 2025-09-06T13:42:44.590Z

Learnt from: lazysegtree
PR: yorukot/superfile#1039
File: src/internal/ui/zoxide/model.go:53-54
Timestamp: 2025-09-06T13:42:44.590Z
Learning: The zoxide modal in src/internal/ui/zoxide/model.go is missing handling for common.Hotkeys.Quit when zClient is nil (lines 52-54), only handling ConfirmTyping and CancelTyping. This creates inconsistency with other modals like sort options menu, help menu, and notify model which all properly handle the Quit hotkey. The prompt modal has the same inconsistency.

Applied to files:

• src/internal/key_function.go

📚 Learning: 2025-09-04T07:24:30.872Z

Learnt from: lazysegtree
PR: yorukot/superfile#1041
File: src/internal/default_config.go:38-38
Timestamp: 2025-09-04T07:24:30.872Z
Learning: In the superfile codebase, the main model struct has a zClient field for zoxide directory tracking, and the trackDirectoryWithZoxide function in model.go checks if m.zClient is nil before proceeding. When reviewing model initialization functions like defaultModelConfig, ensure all struct fields are properly assigned, especially external service clients like zClient that enable core functionality.

Applied to files:

• src/internal/ui/zoxide/test_helpers.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and Test (ubuntu-latest)

🔇 Additional comments (8)

src/internal/ui/zoxide/render.go (3)

11-29: LGTM!

The rendering logic is clear and correctly handles the nil client case, text input display, and result list rendering.

---

31-42: LGTM!

The visible range calculation is correct with proper bounds checking, and the delegation to helper methods maintains clean separation of concerns.

---

63-78: LGTM!

The scroll indicator logic correctly displays arrows based on the current scroll position and properly manages section separators.

src/internal/ui/zoxide/render_test.go (5)

10-16: LGTM!

The test correctly validates the nil client fallback rendering.

---

18-24: LGTM!

The test correctly validates the empty results rendering.

---

26-42: LGTM!

The test correctly validates that all results and their formatted scores appear in the rendered output.

---

44-51: LGTM!

The test correctly validates that the text input value appears in the rendered output.

---

53-113: LGTM!

The table-driven test provides comprehensive coverage of scroll indicator scenarios with clear expectations for each case.

[codescene-delta-analysis]

Gates Failed
Enforce critical code health rules (1 file with Bumpy Road Ahead)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Enforce critical code health rules	Violations	Code Health Impact
model_zoxide_test.go	1 critical rule	9.40	Suppress

Quality Gate Profile: The Bare Minimum
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.