fix: Allow j and k keys in zoxide

[lazysegtree]

Summary by CodeRabbit

• New Features
  • Zoxide panel now supports multi-word queries, improving suggestion relevance.
• Bug Fixes
  • Prevents accidental list navigation when typing alphanumeric characters in the zoxide input, ensuring a smoother typing experience.
• Style
  • Result list shows scores with clearer numeric formatting and improved alignment for easier scanning.

[coderabbitai]

Walkthrough

The zoxide panel now ignores alphanumeric keys for list navigation when in text input mode, tokenizes input using strings.Fields, calls QueryAll with variadic tokens, adjusts score rendering format, and adds a new isKeyAlphaNum helper in utils. Imports updated accordingly.

Changes

Cohort / File(s)	Summary
Zoxide panel input and rendering src/internal/ui/zoxide/model.go	Guard ListUp/ListDown against alphanumeric keys during text input; tokenize input via strings.Fields; call QueryAll with variadic tokens; change score display to "%6.1f"; add strings import and comment tweaks.
Utility key classifier src/internal/ui/zoxide/utils.go	Add isKeyAlphaNum(tea.KeyMsg) helper using unicode checks; update imports to include bubbletea (tea) and unicode; no other functional changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant ZoxidePanel as Zoxide Panel (model.go)
  participant Utils as utils.isKeyAlphaNum
  participant Zox as zoxide.QueryAll

  User->>ZoxidePanel: KeyMsg
  ZoxidePanel->>Utils: isKeyAlphaNum(msg)
  alt In text input mode AND alphanumeric
    ZoxidePanel-->>User: Treat as text input (no list nav)
  else
    ZoxidePanel-->>User: Handle ListUp/ListDown normally
  end

  User->>ZoxidePanel: Input changed
  ZoxidePanel->>ZoxidePanel: tokens = strings.Fields(input)
  ZoxidePanel->>Zox: QueryAll(tokens...)
  Zox-->>ZoxidePanel: Results with scores
  ZoxidePanel-->>User: Render results (score as %6.1f)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through fields of tokens split,
Keys tap-tap—lists won’t budge a bit,
When letters flow, the cursor stays,
While queries fan in variadic ways.
Scores now gleam with tidy might—
6.1f in polished light.
boop boop, zoxide set just right! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title accurately summarizes the primary change of enabling the j and k keys in the zoxide UI by preventing them from triggering navigation and allowing them as input. It is concise, focused, and directly reflects the main update in the changeset.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch zoxide_fix

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b69ac02 and 3d69e77.

📒 Files selected for processing (2)

• src/internal/ui/zoxide/model.go (4 hunks)
• src/internal/ui/zoxide/utils.go (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/default_config.go:16-16
Timestamp: 2025-07-27T07:40:51.938Z
Learning: lazysegtree prefers simpler implementation approaches when the alternatives are significantly more complex, even if the alternatives might be architecturally cleaner, prioritizing maintainability and avoiding over-engineering.

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/default_config.go:16-16
Timestamp: 2025-07-27T07:40:51.938Z
Learning: lazysegtree prefers simpler implementation approaches when the alternatives are significantly more complex, even if the alternatives might be architecturally cleaner, prioritizing maintainability and avoiding over-engineering.

Learnt from: lazysegtree
PR: yorukot/superfile#969
File: src/internal/key_function.go:40-40
Timestamp: 2025-08-03T09:34:55.721Z
Learning: lazysegtree emphasizes proper dependency direction in software architecture, preferring that low-level components (like modal handlers) should not depend on high-level components (like the main model object). He also prioritizes performance considerations, noting that creating objects on every keypress in hot code paths like key handling is inefficient and should be avoided.

Learnt from: lazysegtree
PR: yorukot/superfile#1013
File: src/internal/model_render.go:329-341
Timestamp: 2025-08-29T14:11:21.380Z
Learning: lazysegtree prefers to defer help menu rendering optimizations and other technical debt improvements to separate GitHub issues when the current PR scope has grown too large, maintaining focus on the primary refactoring objectives while tracking performance improvements for future work.

Learnt from: lazysegtree
PR: yorukot/superfile#985
File: src/internal/model.go:0-0
Timestamp: 2025-08-11T01:49:30.040Z
Learning: lazysegtree prefers maintaining code correctness through proper design and invariants rather than adding defensive bounds checks at every slice access point, viewing such defensive programming as "duct taping" that can mask actual bugs instead of fixing them at their source.

Learnt from: lazysegtree
PR: yorukot/superfile#973
File: src/internal/ui/processbar/model_update.go:7-27
Timestamp: 2025-08-03T14:49:31.221Z
Learning: lazysegtree prefers to keep test-only code simple without adding production-level concerns like goroutine synchronization, cancellation contexts, or complex lifecycle management, even when such patterns might prevent potential issues, since the complexity isn't justified for test utilities.

Learnt from: lazysegtree
PR: yorukot/superfile#1044
File: src/internal/utils/file_utils.go:149-149
Timestamp: 2025-09-09T13:29:11.771Z
Learning: lazysegtree prefers to keep PR scope focused on the primary objectives and considers pre-existing technical debt issues as out of scope for migration/refactoring PRs, preferring to defer such issues to separate GitHub issues rather than expanding the current PR scope.

Learnt from: lazysegtree
PR: yorukot/superfile#950
File: src/internal/ui/metadata/README.md:7-7
Timestamp: 2025-07-24T03:46:29.516Z
Learning: lazysegtree prefers to defer comprehensive unit testing to separate PRs when the current PR has grown too large, maintaining focus on the primary refactoring objectives while tracking testing requirements in dedicated GitHub issues.

Learnt from: lazysegtree
PR: yorukot/superfile#967
File: src/internal/key_function.go:45-47
Timestamp: 2025-08-02T11:47:07.713Z
Learning: lazysegtree prefers to track technical debt and architectural improvements in dedicated GitHub issues when they are identified during PR reviews but are beyond the scope of the current PR, particularly for complex refactoring needs like input handling architecture that would require significant changes.

Learnt from: lazysegtree
PR: yorukot/superfile#963
File: src/internal/handle_file_operations.go:567-570
Timestamp: 2025-07-27T08:49:09.687Z
Learning: lazysegtree prefers to defer technical debt issues like model mutation concerns to later PRs when the current PR has already grown too large, maintaining focus on the primary objectives while acknowledging the need to track such issues for future work.

🔇 Additional comments (5)

src/internal/ui/zoxide/utils.go (1)

65-71: LGTM! Clean alphanumeric key detection.

The implementation correctly identifies single alphanumeric characters by:

1. Converting the key message to runes
2. Verifying exactly one rune exists
3. Checking Unicode letter or number classification

This approach properly handles the PR objective of allowing 'j' and 'k' keys for text input in the zoxide panel.

src/internal/ui/zoxide/model.go (4)

67-74: Navigation guard successfully prevents 'j'/'k' from conflicting with text input.

The logic correctly addresses the PR objective:

• Alphanumeric keys (including 'j' and 'k') now pass through to text input
• Non-alphanumeric navigation hotkeys still trigger list navigation
• Clear comments explain the intent

---

184-184: Score format change maintains alignment.

The format change to "%6.1f" provides:

• Fixed width of 6 characters (including decimal point and digit)
• One decimal place precision
• Consistent alignment in the result list

This appears correct for displaying zoxide scores. The comment on line 180 mentions "score(5)" but the format is now 6 characters wide - verify this doesn't cause layout issues.

Consider testing with various score values (e.g., 0.5, 10.7, 100.0, 1000.0) to ensure the 6-character width handles the expected range without truncation or overflow.

---

122-122: No changes needed: empty or whitespace-only input yields an empty token slice and QueryAll() returns all results as intended per the existing comment.

---

125-125: Verify zoxidelib.Client.QueryAll accepts variadic strings
The call m.zClient.QueryAll(query...) assumes QueryAll is declared as func (c *Client) QueryAll(...string) ([]Result, error). Manually confirm its signature in the go-zoxide library and adjust the call if it only accepts a slice.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[lazysegtree]

API rate limit for zoxide - https://github.com/yorukot/superfile/actions/runs/18200477662/job/51817841643?pr=1102

[lazysegtree]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.