fix(filePanel): allow focusType to be set correctly

[faisal-990]

The defaultFilePanel function previously hardcoded focusType to 'focus', causing multiple panels to appear focused simultaneously.

Now, defaultFilePanel accepts a focusType parameter, allowing callers to initialize panels with the correct focus state. This ensures only one panel is focused at initialization, and others are set to 'noneFocus' or 'secondFocus' as needed.

Fixes the inconsistent panel focus issue introduced in PR #759.

Summary by CodeRabbit

• New Features
  • Added per-panel focus behavior: the first panel now receives primary focus while additional panels get secondary focus. This improves keyboard navigation, clarifies which panel is active, and reduces accidental interactions when working with multiple panels.
• Style
  • Minor formatting cleanup in sorting options with no impact on functionality or behavior.

[coderabbitai]

Walkthrough

Updates focus handling for file panels: the first panel receives focus and subsequent panels receive secondFocus. The defaultFilePanel function now accepts a focus type parameter, and filePanelSlice computes and passes the appropriate focus type. Minor formatting adjustment to a sorting options slice.

Changes

Cohort / File(s)	Summary of Changes
Per-panel focus handling src/internal/type_utils.go	Added per-panel focus selection in filePanelSlice. Changed defaultFilePanel signature to func defaultFilePanel(dir string, currentFocusType filePanelFocusType) filePanel and used the provided currentFocusType to set focusType. Minor formatting change to sorting options.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor App
  participant TU as type_utils.go
  participant FP as FilePanel

  App->>TU: filePanelSlice(dirs)
  loop for each dir in dirs
    TU->>TU: determine focusType (first: focus, others: secondFocus)
    TU->>FP: defaultFilePanel(dir, focusType)
    activate FP
    FP-->>TU: filePanel with focusType
    deactivate FP
  end
  TU-->>App: []filePanel (first focused, others secondFocused)
  note over App,TU: Control flow modified to pass focusType into panel construction

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• Bug: All file panels initialized with focus type causing inconsistent state #1030 — Implements per-panel focus by passing focusType into defaultFilePanel and assigning focus/secondFocus in filePanelSlice.

Poem

A bunny taps keys with nimble might,
First pane aglow, the others light,
Focus hops—then lands just right,
Panels line up, left to right,
Thump-thump! the UI feels so bright. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/internal/type_utils.go (2)

53-74: Signature change ripple: ensure all call sites updated; consider a temporary compatibility helper

Changing defaultFilePanel to require a filePanelFocusType is sensible. Verify all invocations compile and pass an explicit focus type. If you want a softer transition, add a small wrapper (unexported) used only by legacy code and remove it in a follow-up.

Example wrapper (optional, short-lived):

// deprecated: prefer defaultFilePanel(dir, focusType)
func defaultFocusedFilePanel(dir string) filePanel {
	return defaultFilePanel(dir, focus)
}

One nit: currentFocusType reads more clearly as initialFocusType.

-func defaultFilePanel(dir string, currentFocusType filePanelFocusType) filePanel {
+func defaultFilePanel(dir string, initialFocusType filePanelFocusType) filePanel {
   return filePanel{
     ...
-    focusType:        currentFocusType,
+    focusType:        initialFocusType,
     ...
   }
}

---

53-74: Keep sort options height in sync with the options list

Hard-coding height: 4 risks drift. Compute it from the options slice to avoid future mismatches.

-func defaultFilePanel(dir string, currentFocusType filePanelFocusType) filePanel {
-	return filePanel{
+func defaultFilePanel(dir string, currentFocusType filePanelFocusType) filePanel {
+	opts := []string{
+		string(sortingName),
+		string(sortingSize),
+		string(sortingDateModified),
+		string(sortingFileType),
+	}
+	return filePanel{
 		render:   0,
 		cursor:   0,
 		location: dir,
 		sortOptions: sortOptionsModel{
 			width:  20,
-			height: 4,
+			height: len(opts),
 			open:   false,
 			cursor: common.Config.DefaultSortType,
 			data: sortOptionsModelData{
-				options: []string{
-					string(sortingName), string(sortingSize),
-					string(sortingDateModified), string(sortingFileType),
-				},
+				options: opts,
 				selected: common.Config.DefaultSortType,
 				reversed: common.Config.SortOrderReversed,
 			},
 		},
 		panelMode:        browserMode,
 		focusType:        currentFocusType,
 		directoryRecords: make(map[string]directoryRecord),
 		searchBar:        common.GenerateSearchBar(),
 	}
 }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fdcaf98 and 73cb291.

📒 Files selected for processing (1)

• src/internal/type_utils.go (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:00:32.688Z
Learning: In PR #767 for yorukot/superfile, the focus is on moving code (especially sidebar-related functionality) to a more organized structure without changing functionality. Pre-existing issues should be ignored since the purpose is code reorganization, not fixing existing problems.

🧬 Code graph analysis (1)

src/internal/type_utils.go (4)

src/internal/handle_panel_navigation.go (5)

• m (136-145)
• m (160-171)
• m (148-157)
• m (78-109)
• m (174-186)

src/internal/function.go (1)

• returnFocusType (58-63)

src/internal/type.go (1)

• filePanels (149-155)

src/internal/handle_panel_movement.go (1)

• m (107-122)

🔇 Additional comments (1)

src/internal/type_utils.go (1)

42-48: Initialization logic verified
Confirmed no other default initialization path assigns focus to all panels; navigation assignments are expected behavior.

[faisal-990]

PR #1033 raised for the fix. Kindly review the changes.

[lazysegtree]

LGTM. Thanks @faisal-990

[lazysegtree]

Failures due to

• Fix the flaky test in windows. #938

[faisal-990]

@lazysegtree thanks for the review . Do you have some suggestions to refactor this filePanelFocusType typed constant? or should i change the names to something more intuitive ,and make the default focusType to noneFocus instead of second Focus.
Also i would like to look into this #938 issue , if it still needs work ?

[lazysegtree]

Do you have some suggestions to refactor this filePanelFocusType typed constant?

The constants themselves dont make any sense. Only thing there should be is isFocussed bool variable. The entire usage of this focusType needs to be fixed, and replaced with a simpler bool variable.

[lazysegtree]

Yes #938 Needs work. The tests are flaky and fails and works on retry.

[faisal-990]

Alright , so i would like to work on these issues , if possible kindly assign me these #1033 and #938 .

[lazysegtree]

Github isn't letting me assign you. You can just comment on them saying you are working on it.