Skip to content

chore(deps): update graphql-go-tools to v2.0.0-rc.254#2539

Merged
jensneuse merged 1 commit intomainfrom
jensneuse/update-gql-tools-rc254
Feb 20, 2026
Merged

chore(deps): update graphql-go-tools to v2.0.0-rc.254#2539
jensneuse merged 1 commit intomainfrom
jensneuse/update-gql-tools-rc254

Conversation

@jensneuse
Copy link
Copy Markdown
Member

@jensneuse jensneuse commented Feb 20, 2026

Summary by CodeRabbit

  • Chores
    • Updated project dependencies across router modules to latest stable versions for improved functionality and compatibility.

Bumps github.com/wundergraph/graphql-go-tools/v2 from v2.0.0-rc.253 to v2.0.0-rc.254 in the router and router-tests modules. Also upgrades the transitive dependency wundergraph/astjson from v1.0.0 to v1.1.0. All existing tests pass with no compiler errors.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 20, 2026

Walkthrough

Two Go module dependencies are upgraded in router/go.mod and router-tests/go.mod: github.com/wundergraph/astjson (v1.0.0 → v1.1.0) and github.com/wundergraph/graphql-go-tools/v2 (v2.0.0-rc.253 → v2.0.0-rc.254).

Changes

Cohort / File(s) Summary
Go Module Dependency Updates
router/go.mod, router-tests/go.mod
Upgrade github.com/wundergraph/astjson to v1.1.0 and github.com/wundergraph/graphql-go-tools/v2 to v2.0.0-rc.254 in both modules.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating graphql-go-tools to v2.0.0-rc.254. It is concise, specific, and clearly identifies the primary dependency update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 20, 2026

❌ Internal Query Planner CI checks failed

The Internal Query Planner CI checks failed in the celestial repository, and this is going to stop the merge of this PR.
If you are part of the WunderGraph organization, you can see the PR with more details.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@router-tests/go.mod`:
- Around line 25-30: The call to NewVariablesNormalizer() is now missing the
required boolean parameter enableFieldArgumentMapping; update the call site
where NewVariablesNormalizer is invoked (the operation processing/normalization
code that currently calls NewVariablesNormalizer()) to pass the appropriate
bool—either an existing configuration flag (e.g., enableFieldArgumentMapping or
similar) if one exists in the surrounding context, or a concrete literal (true
or false) reflecting whether field-argument mapping should be enabled; ensure
you call NewVariablesNormalizer(enableFieldArgumentMapping) instead of the
zero-argument form.

In `@router/go.mod`:
- Line 34: The call to astnormalization.NewVariablesNormalizer() in
operation_processor.go must be updated to the new rc.254 signature that requires
a boolean enableFieldArgumentMapping; locate the struct/field setting where
variablesNormalizer is assigned (variablesNormalizer:
astnormalization.NewVariablesNormalizer()) and change the call to pass the
appropriate boolean (true or false) for enableFieldArgumentMapping to match the
desired behavior in NewVariablesNormalizer, then run a build to verify
compilation.

Comment on lines +25 to +30
github.com/wundergraph/astjson v1.1.0
github.com/wundergraph/cosmo/demo v0.0.0-20260213130455-6e3277e7b850
github.com/wundergraph/cosmo/demo/pkg/subgraphs/projects v0.0.0-20250715110703-10f2e5f9c79e
github.com/wundergraph/cosmo/router v0.0.0-20260213130455-6e3277e7b850
github.com/wundergraph/cosmo/router-plugin v0.0.0-20250808194725-de123ba1c65e
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.253
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.254
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# Search for NewVariablesNormalizer usage in router-tests
rg -n 'NewVariablesNormalizer' router-tests/ --type go

# Search for astnormalization imports
rg -n 'astnormalization' router-tests/ --type go

# Check go.mod and go.sum for graphql-go-tools and astjson versions
cat -n router-tests/go.mod | grep -E '(graphql-go-tools|astjson)'
echo "---"
cat -n router-tests/go.sum | grep -E 'graphql-go-tools.*v2|astjson'

Repository: wundergraph/cosmo

Length of output: 681


🏁 Script executed:

# Broader search for astnormalization in router-tests
rg -n 'astnormalization' router-tests/ || echo "Not found in router-tests"

# Check if router module's operation_processor.go uses NewVariablesNormalizer
rg -n 'NewVariablesNormalizer' router/ --type go -A 2

# Verify go.mod imports in router-tests - check if astnormalization is even directly imported
rg -n 'package astnormalization|from.*astnormalization|import.*astnormalization' router-tests/ || echo "No direct imports found"

Repository: wundergraph/cosmo

Length of output: 404


Update router/core/operation_processor.go line 1444 to pass the required boolean parameter to NewVariablesNormalizer().

The graphql-go-tools rc.254 update requires astnormalization.NewVariablesNormalizer(enableFieldArgumentMapping bool) to accept a boolean parameter, but the current call at router/core/operation_processor.go:1444 provides no argument. The dependency versions in router-tests/go.mod and go.sum are correctly synced; the issue is in the router module's API usage.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@router-tests/go.mod` around lines 25 - 30, The call to
NewVariablesNormalizer() is now missing the required boolean parameter
enableFieldArgumentMapping; update the call site where NewVariablesNormalizer is
invoked (the operation processing/normalization code that currently calls
NewVariablesNormalizer()) to pass the appropriate bool—either an existing
configuration flag (e.g., enableFieldArgumentMapping or similar) if one exists
in the surrounding context, or a concrete literal (true or false) reflecting
whether field-argument mapping should be enabled; ensure you call
NewVariablesNormalizer(enableFieldArgumentMapping) instead of the zero-argument
form.

github.com/tidwall/sjson v1.2.5
github.com/twmb/franz-go v1.16.1
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.253
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.254
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# Search for astnormalization usage in router code
rg -n 'NewVariablesNormalizer|astnormalization' router --type go -A 2 -B 2

Repository: wundergraph/cosmo

Length of output: 16432


🏁 Script executed:

# Search for astjson usage in router code
rg -n 'astjson' router --type go -A 2 -B 2

Repository: wundergraph/cosmo

Length of output: 34324


🏁 Script executed:

# Show the go.mod entries for the bumped dependencies
head -n 100 router/go.mod | tail -n 70

Repository: wundergraph/cosmo

Length of output: 2835


🏁 Script executed:

# Verify the exact line and context for NewVariablesNormalizer usage
sed -n '1440,1450p' router/core/operation_processor.go

Repository: wundergraph/cosmo

Length of output: 691


Update NewVariablesNormalizer() call in operation_processor.go to match rc.254 API signature.

The graphql-go-tools/v2 rc.254 API has changed: NewVariablesNormalizer() now requires a boolean parameter enableFieldArgumentMapping. Line 1444 in router/core/operation_processor.go calls it with no arguments and will fail to compile:

variablesNormalizer: astnormalization.NewVariablesNormalizer(),

Update to:

variablesNormalizer: astnormalization.NewVariablesNormalizer(false), // or true based on intended behavior

The astjson 1.1.0 bump appears compatible with current usage patterns across the codebase.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@router/go.mod` at line 34, The call to
astnormalization.NewVariablesNormalizer() in operation_processor.go must be
updated to the new rc.254 signature that requires a boolean
enableFieldArgumentMapping; locate the struct/field setting where
variablesNormalizer is assigned (variablesNormalizer:
astnormalization.NewVariablesNormalizer()) and change the call to pass the
appropriate boolean (true or false) for enableFieldArgumentMapping to match the
desired behavior in NewVariablesNormalizer, then run a build to verify
compilation.

Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.00%. Comparing base (480efa5) to head (ada5c38).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2539      +/-   ##
==========================================
- Coverage   62.09%   61.00%   -1.10%     
==========================================
  Files         239      239              
  Lines       25424    25423       -1     
==========================================
- Hits        15788    15510     -278     
- Misses       8293     8589     +296     
+ Partials     1343     1324      -19     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants