chore(deps): update graphql-go-tools to v2.0.0-rc.254#2539
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughTwo Go module dependencies are upgraded in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
❌ Internal Query Planner CI checks failedThe Internal Query Planner CI checks failed in the celestial repository, and this is going to stop the merge of this PR. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@router-tests/go.mod`:
- Around line 25-30: The call to NewVariablesNormalizer() is now missing the
required boolean parameter enableFieldArgumentMapping; update the call site
where NewVariablesNormalizer is invoked (the operation processing/normalization
code that currently calls NewVariablesNormalizer()) to pass the appropriate
bool—either an existing configuration flag (e.g., enableFieldArgumentMapping or
similar) if one exists in the surrounding context, or a concrete literal (true
or false) reflecting whether field-argument mapping should be enabled; ensure
you call NewVariablesNormalizer(enableFieldArgumentMapping) instead of the
zero-argument form.
In `@router/go.mod`:
- Line 34: The call to astnormalization.NewVariablesNormalizer() in
operation_processor.go must be updated to the new rc.254 signature that requires
a boolean enableFieldArgumentMapping; locate the struct/field setting where
variablesNormalizer is assigned (variablesNormalizer:
astnormalization.NewVariablesNormalizer()) and change the call to pass the
appropriate boolean (true or false) for enableFieldArgumentMapping to match the
desired behavior in NewVariablesNormalizer, then run a build to verify
compilation.
| github.com/wundergraph/astjson v1.1.0 | ||
| github.com/wundergraph/cosmo/demo v0.0.0-20260213130455-6e3277e7b850 | ||
| github.com/wundergraph/cosmo/demo/pkg/subgraphs/projects v0.0.0-20250715110703-10f2e5f9c79e | ||
| github.com/wundergraph/cosmo/router v0.0.0-20260213130455-6e3277e7b850 | ||
| github.com/wundergraph/cosmo/router-plugin v0.0.0-20250808194725-de123ba1c65e | ||
| github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.253 | ||
| github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.254 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Search for NewVariablesNormalizer usage in router-tests
rg -n 'NewVariablesNormalizer' router-tests/ --type go
# Search for astnormalization imports
rg -n 'astnormalization' router-tests/ --type go
# Check go.mod and go.sum for graphql-go-tools and astjson versions
cat -n router-tests/go.mod | grep -E '(graphql-go-tools|astjson)'
echo "---"
cat -n router-tests/go.sum | grep -E 'graphql-go-tools.*v2|astjson'Repository: wundergraph/cosmo
Length of output: 681
🏁 Script executed:
# Broader search for astnormalization in router-tests
rg -n 'astnormalization' router-tests/ || echo "Not found in router-tests"
# Check if router module's operation_processor.go uses NewVariablesNormalizer
rg -n 'NewVariablesNormalizer' router/ --type go -A 2
# Verify go.mod imports in router-tests - check if astnormalization is even directly imported
rg -n 'package astnormalization|from.*astnormalization|import.*astnormalization' router-tests/ || echo "No direct imports found"Repository: wundergraph/cosmo
Length of output: 404
Update router/core/operation_processor.go line 1444 to pass the required boolean parameter to NewVariablesNormalizer().
The graphql-go-tools rc.254 update requires astnormalization.NewVariablesNormalizer(enableFieldArgumentMapping bool) to accept a boolean parameter, but the current call at router/core/operation_processor.go:1444 provides no argument. The dependency versions in router-tests/go.mod and go.sum are correctly synced; the issue is in the router module's API usage.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@router-tests/go.mod` around lines 25 - 30, The call to
NewVariablesNormalizer() is now missing the required boolean parameter
enableFieldArgumentMapping; update the call site where NewVariablesNormalizer is
invoked (the operation processing/normalization code that currently calls
NewVariablesNormalizer()) to pass the appropriate bool—either an existing
configuration flag (e.g., enableFieldArgumentMapping or similar) if one exists
in the surrounding context, or a concrete literal (true or false) reflecting
whether field-argument mapping should be enabled; ensure you call
NewVariablesNormalizer(enableFieldArgumentMapping) instead of the zero-argument
form.
| github.com/tidwall/sjson v1.2.5 | ||
| github.com/twmb/franz-go v1.16.1 | ||
| github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.253 | ||
| github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.254 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Search for astnormalization usage in router code
rg -n 'NewVariablesNormalizer|astnormalization' router --type go -A 2 -B 2Repository: wundergraph/cosmo
Length of output: 16432
🏁 Script executed:
# Search for astjson usage in router code
rg -n 'astjson' router --type go -A 2 -B 2Repository: wundergraph/cosmo
Length of output: 34324
🏁 Script executed:
# Show the go.mod entries for the bumped dependencies
head -n 100 router/go.mod | tail -n 70Repository: wundergraph/cosmo
Length of output: 2835
🏁 Script executed:
# Verify the exact line and context for NewVariablesNormalizer usage
sed -n '1440,1450p' router/core/operation_processor.goRepository: wundergraph/cosmo
Length of output: 691
Update NewVariablesNormalizer() call in operation_processor.go to match rc.254 API signature.
The graphql-go-tools/v2 rc.254 API has changed: NewVariablesNormalizer() now requires a boolean parameter enableFieldArgumentMapping. Line 1444 in router/core/operation_processor.go calls it with no arguments and will fail to compile:
variablesNormalizer: astnormalization.NewVariablesNormalizer(),Update to:
variablesNormalizer: astnormalization.NewVariablesNormalizer(false), // or true based on intended behaviorThe astjson 1.1.0 bump appears compatible with current usage patterns across the codebase.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@router/go.mod` at line 34, The call to
astnormalization.NewVariablesNormalizer() in operation_processor.go must be
updated to the new rc.254 signature that requires a boolean
enableFieldArgumentMapping; locate the struct/field setting where
variablesNormalizer is assigned (variablesNormalizer:
astnormalization.NewVariablesNormalizer()) and change the call to pass the
appropriate boolean (true or false) for enableFieldArgumentMapping to match the
desired behavior in NewVariablesNormalizer, then run a build to verify
compilation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
==========================================
- Coverage 62.09% 61.00% -1.10%
==========================================
Files 239 239
Lines 25424 25423 -1
==========================================
- Hits 15788 15510 -278
- Misses 8293 8589 +296
+ Partials 1343 1324 -19 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Bumps
github.com/wundergraph/graphql-go-tools/v2fromv2.0.0-rc.253tov2.0.0-rc.254in therouterandrouter-testsmodules. Also upgrades the transitive dependencywundergraph/astjsonfromv1.0.0tov1.1.0. All existing tests pass with no compiler errors.Checklist