Skip to content

fix: fix selecting parent of unique nodes#2593

Merged
devsergiy merged 3 commits intomainfrom
david/eng-9097-fix-wrong-external-parent-selection-when-use-interfaces
Mar 6, 2026
Merged

fix: fix selecting parent of unique nodes#2593
devsergiy merged 3 commits intomainfrom
david/eng-9097-fix-wrong-external-parent-selection-when-use-interfaces

Conversation

@Aenimus
Copy link
Copy Markdown
Member

@Aenimus Aenimus commented Mar 5, 2026

Summary by CodeRabbit

  • Chores
    • Updated dependency versions used by routing components to newer releases across build modules.
    • Changes are limited to build configuration; no functional, public API, or runtime behavior changes are expected for end users.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 10f1adc2-bfc4-4f97-8868-c0a2d6c1f9e6

📥 Commits

Reviewing files that changed from the base of the PR and between 442f143 and 6867bc1.

⛔ Files ignored due to path filters (2)
  • router-tests/go.sum is excluded by !**/*.sum
  • router/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • router-tests/go.mod
  • router/go.mod
🚧 Files skipped from review as they are similar to previous changes (2)
  • router-tests/go.mod
  • router/go.mod

Walkthrough

Updated the github.com/wundergraph/graphql-go-tools/v2 dependency from v2.0.0-rc.257 to v2.0.0-rc.261 in two go.mod files. No other code, exported APIs, or logic changed.

Changes

Cohort / File(s) Summary
Dependency Updates
router-tests/go.mod, router/go.mod
Bumped github.com/wundergraph/graphql-go-tools/v2 from v2.0.0-rc.257 to v2.0.0-rc.261. No other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'fix: fix selecting parent of unique nodes' does not match the actual changes, which only update dependency versions in go.mod files. Update the PR title to reflect the actual changes, such as 'chore: update graphql-go-tools dependency to v2.0.0-rc.261' or similar to accurately describe the dependency version updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-59698d900ccb8586f8721219760d1fe9b6a9f88d-nonroot

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.82%. Comparing base (177a1c0) to head (6867bc1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2593      +/-   ##
==========================================
- Coverage   63.29%   62.82%   -0.48%     
==========================================
  Files         244      244              
  Lines       25757    25757              
==========================================
- Hits        16303    16181     -122     
- Misses       8087     8206     +119     
- Partials     1367     1370       +3     

see 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@devsergiy devsergiy merged commit 87af642 into main Mar 6, 2026
52 of 54 checks passed
@devsergiy devsergiy deleted the david/eng-9097-fix-wrong-external-parent-selection-when-use-interfaces branch March 6, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants