Skip to content

Conversation

@devsergiy
Copy link
Member

@devsergiy devsergiy commented Jul 14, 2025

fixes ENG-7397
fixes ENG-7355
fixes ENG-7228

Bump engine 2.0.0-rc.210 (2025-07-22)

Bug Fixes

  • planner fixes for parent entity jumps and unique nodes selections (#1230) (1a7ed16)

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated backend dependencies to more specific versions for improved stability. No user-facing changes.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@coderabbitai
Copy link

coderabbitai bot commented Jul 14, 2025

Walkthrough

The dependency version for github.com/wundergraph/graphql-go-tools/v2 was updated from v2.0.0-rc.209 to v2.0.0-rc.210 in both router/go.mod and router-tests/go.mod. Additionally, two other dependencies in router-tests/go.mod were updated to newer commit versions. No code declarations were altered.

Changes

File(s) Change Summary
router/go.mod Updated github.com/wundergraph/graphql-go-tools/v2 version from v2.0.0-rc.209 to v2.0.0-rc.210.
router-tests/go.mod Updated github.com/wundergraph/graphql-go-tools/v2 to v2.0.0-rc.210; updated github.com/wundergraph/cosmo/demo and github.com/wundergraph/cosmo/router to newer commit versions.

Estimated code review effort

1 (~5 minutes)

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e88e1c and 628e3e3.

⛔ Files ignored due to path filters (2)
  • router-tests/go.sum is excluded by !**/*.sum
  • router/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • router-tests/go.mod (1 hunks)
  • router/go.mod (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • router/go.mod
  • router-tests/go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build-router
  • GitHub Check: integration_test (./events)
  • GitHub Check: build_push_image (nonroot)
  • GitHub Check: build_push_image
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: image_scan (nonroot)
  • GitHub Check: image_scan
  • GitHub Check: build_test
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sergiy/eng-7397-fix-planner-parent-entity-jump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
router/go.mod (1)

34-36: Clarify & verify the pseudo-version pin

You replaced the tagged release v2.0.0-rc.203 with a pseudo-version on top of rc.202.
Two follow-ups are worth doing:

  1. Add a short inline rationale (commit hash + reason) so future readers understand why this exact SHA must stay.
  2. Double-check that commit cd6746620ea7 is before the breaking “attribute rename” change alluded to in the comment.
-	github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.202.0.20250714122345-cd6746620ea7
-	// Do not upgrade, it renames attributes we rely on
+	// Pinned to cd6746620ea7 (post-rc.202) – newer tags rename attributes we rely on.
+	github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.202.0.20250714122345-cd6746620ea7
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc2a400 and 99ac9f3.

⛔ Files ignored due to path filters (1)
  • router/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • router/go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: build-router
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: image_scan
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: integration_test (./events)
  • GitHub Check: Analyze (go)
  • GitHub Check: build_push_image
  • GitHub Check: build_test

@github-actions
Copy link

github-actions bot commented Jul 14, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-5bdce9d03acceaf6fad1efbe6ec28fd34fd94efd

@JivusAyrus JivusAyrus self-requested a review July 21, 2025 08:32
@devsergiy devsergiy force-pushed the sergiy/eng-7397-fix-planner-parent-entity-jump branch from 6543b02 to 2e88e1c Compare July 22, 2025 18:07
@devsergiy devsergiy changed the title chore: tmp engine version fix: planner fixes for parent entity jumps and unique nodes selections Jul 22, 2025
@devsergiy devsergiy force-pushed the sergiy/eng-7397-fix-planner-parent-entity-jump branch from 2e88e1c to 628e3e3 Compare July 22, 2025 18:49
@devsergiy devsergiy merged commit 3c54a59 into main Jul 22, 2025
39 of 40 checks passed
@devsergiy devsergiy deleted the sergiy/eng-7397-fix-planner-parent-entity-jump branch July 22, 2025 19:20
@coderabbitai coderabbitai bot mentioned this pull request Oct 29, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants