-
Notifications
You must be signed in to change notification settings - Fork 193
fix: planner fixes for parent entity jumps and unique nodes selections #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: planner fixes for parent entity jumps and unique nodes selections #2044
Conversation
WalkthroughThe dependency version for Changes
Estimated code review effort1 (~5 minutes) Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
router/go.mod (1)
34-36: Clarify & verify the pseudo-version pinYou replaced the tagged release
v2.0.0-rc.203with a pseudo-version on top ofrc.202.
Two follow-ups are worth doing:
- Add a short inline rationale (commit hash + reason) so future readers understand why this exact SHA must stay.
- Double-check that commit
cd6746620ea7is before the breaking “attribute rename” change alluded to in the comment.- github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.202.0.20250714122345-cd6746620ea7 - // Do not upgrade, it renames attributes we rely on + // Pinned to cd6746620ea7 (post-rc.202) – newer tags rename attributes we rely on. + github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.202.0.20250714122345-cd6746620ea7
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
router/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
router/go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: build-router
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: integration_test (./telemetry)
- GitHub Check: image_scan
- GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
- GitHub Check: integration_test (./events)
- GitHub Check: Analyze (go)
- GitHub Check: build_push_image
- GitHub Check: build_test
Router image scan passed✅ No security vulnerabilities found in image: |
6543b02 to
2e88e1c
Compare
2e88e1c to
628e3e3
Compare
fixes ENG-7397
fixes ENG-7355
fixes ENG-7228
Bump engine 2.0.0-rc.210 (2025-07-22)
Bug Fixes
Summary by CodeRabbit
Summary by CodeRabbit
Checklist