-
Notifications
You must be signed in to change notification settings - Fork 193
fix: go.mod references to security merge commit #2048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDependency versions were updated in the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Router image scan passed✅ No security vulnerabilities found in image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
demo/go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
demo/go.mod(4 hunks)router-tests/go.mod(1 hunks)
🔇 Additional comments (5)
router-tests/go.mod (1)
25-25: Confirm the need forastjsonas a direct dependency
github.com/wundergraph/astjsonis promoted from indirect to direct, yet no code changes accompany this bump in the PR. If the package is not imported directly inrouter-tests,go mod tidywill revert this.
Double-check that a forthcoming change really imports it; otherwise keep it indirect.demo/go.mod (4)
14-14: Router bumped – verify localreplacedirectives & downstream callers
github.com/wundergraph/cosmo/routernow tracks commit10f2e5f9c79e.
Ensure every workspacereplace(e.g. inrouter-tests/go.mod) or downstream repo is also updated so that a single router SHA is built everywhere; otherwisego work/go mod vendorwill pick the highest version and silently shadow older builds.
42-42: New indirectcep21/circuit/v4– dead code checkThe circuit-breaker library is newly introduced as indirect. If no packages import it directly or via another new dependency, it will vanish on
go mod tidy.
Rungo mod why github.com/cep21/circuit/v4to confirm it is genuinely needed.
63-63: Minor chi patch looks good
go-chi/chipatched from v5.2.1 → v5.2.2. Only bug-fixes, no breaking API; safe bump.
154-154: Large jump ingraphql-go-toolsRC – smoke-test parserRC 186 → RC 203 includes several AST and validation changes. Run router/unit tests that compile query plans to catch regressions early.
Summary by CodeRabbit
Update references to go.mod router
Checklist