chore: upgrade demo to last router release#2631
Conversation
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated Go module dependency versions: bumped Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
==========================================
+ Coverage 62.41% 63.16% +0.74%
==========================================
Files 244 244
Lines 25826 25826
==========================================
+ Hits 16119 16312 +193
+ Misses 8326 8131 -195
- Partials 1381 1383 +2 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@demo/go.mod`:
- Around line 14-15: Update the demo/go.mod entry for
github.com/wundergraph/cosmo/router-tests to the same pseudo-version used for
github.com/wundergraph/cosmo/router (v0.0.0-20260311141102-457b5d860b6e) so the
benchmark test import router-tests/testenv targets the same router snapshot, and
also update the internal router-tests/go.mod pin for
github.com/wundergraph/cosmo/router to that same version; search for the module
names "github.com/wundergraph/cosmo/router" and
"github.com/wundergraph/cosmo/router-tests" and replace the older pseudo-version
with v0.0.0-20260311141102-457b5d860b6e in both places.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3b6a3468-3a4c-4412-bc1a-4e7c326e55ee
⛔ Files ignored due to path filters (1)
demo/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
demo/go.mod
| github.com/wundergraph/cosmo/router v0.0.0-20260311141102-457b5d860b6e | ||
| github.com/wundergraph/cosmo/router-tests v0.0.0-20260213130455-6e3277e7b850 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '== demo/go.mod pins ==\n'
sed -n '13,16p' demo/go.mod
printf '\n== demo imports of router-tests ==\n'
rg -n --type=go -C2 'github\.com/wundergraph/cosmo/router-tests' demo || true
printf '\n== router-tests/go.mod references to router ==\n'
if [ -f router-tests/go.mod ]; then
rg -n -C2 'github\.com/wundergraph/cosmo/router(\s|$)' router-tests/go.mod || true
else
printf 'router-tests/go.mod not present in checkout\n'
fi
printf '\n== other go.mod files pinning router and/or router-tests ==\n'
python - <<'PY'
import pathlib, re
for path in sorted(pathlib.Path('.').rglob('go.mod')):
text = path.read_text()
router = re.search(r'^\s*github\.com/wundergraph/cosmo/router\s+(v\S+)', text, re.M)
tests = re.search(r'^\s*github\.com/wundergraph/cosmo/router-tests\s+(v\S+)', text, re.M)
if router or tests:
print(f'{path}: router={router.group(1) if router else "-"} router-tests={tests.group(1) if tests else "-"}')
PYRepository: wundergraph/cosmo
Length of output: 1905
Align router-tests version with router update.
Line 14 updates github.com/wundergraph/cosmo/router to v0.0.0-20260311141102-457b5d860b6e, but Line 15 leaves github.com/wundergraph/cosmo/router-tests on the older v0.0.0-20260213130455-6e3277e7b850. The benchmark test in demo/cmd/benchmarksubscriptions/benchmark_test.go directly imports router-tests/testenv, so this version skew means the test helper operates against a stale router snapshot. The internal router-tests/go.mod also pins router to v0.0.0-20260213130455-6e3277e7b850, compounding the drift. Update both in the same commit to keep them synchronized.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@demo/go.mod` around lines 14 - 15, Update the demo/go.mod entry for
github.com/wundergraph/cosmo/router-tests to the same pseudo-version used for
github.com/wundergraph/cosmo/router (v0.0.0-20260311141102-457b5d860b6e) so the
benchmark test import router-tests/testenv targets the same router snapshot, and
also update the internal router-tests/go.mod pin for
github.com/wundergraph/cosmo/router to that same version; search for the module
names "github.com/wundergraph/cosmo/router" and
"github.com/wundergraph/cosmo/router-tests" and replace the older pseudo-version
with v0.0.0-20260311141102-457b5d860b6e in both places.
alepane21
requested review from
Noroth,
SkArchon,
devsergiy,
endigma and
jensneuse
as code owners
1 participant
Summary by CodeRabbit
Checklist