Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.99.0 #5944

Merged
merged 9 commits into from
Jul 7, 2023
Merged

Release 1.99.0 #5944

merged 9 commits into from
Jul 7, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jul 6, 2023

Release for Gutenberg Mobile 1.99.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Rename Reusable blocks to Patterns

Fix a crash related to Reanimated when closing the editor

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@@ -196,6 +195,7 @@ private func dummy() {
_ = NSLocalizedString("Line Height", comment: "")
_ = NSLocalizedString("Link inserted", comment: "")
_ = NSLocalizedString("Link Rel", comment: "")
_ = NSLocalizedString("Link Settings", comment: "")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is no longer used in the web version after this change.

@@ -10,8 +10,7 @@ private func dummy() {
_ = NSLocalizedString("%s block, newly available", comment: "translators: Newly available block name. %s: The localized block name")
_ = NSLocalizedString("%s block. Empty", comment: "translators: accessibility text for the media block empty state. %s: media type")
_ = NSLocalizedString("%s block. This block has invalid content", comment: "translators: accessibility text for blocks with invalid content. %d: localized block title")
_ = NSLocalizedString("%s converted to regular block", comment: "translators: %s: name of the reusable block")
_ = NSLocalizedString("%s converted to regular blocks", comment: "translators: %s: name of the reusable block")
_ = NSLocalizedString("%s detached", comment: "translators: %s: name of the synced block")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All strings related to reusable blocks have been updated due to this expected change.

@fluiddot fluiddot marked this pull request as ready for review July 6, 2023 12:07
@geriux geriux self-requested a review July 6, 2023 13:24
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fluiddot fluiddot merged commit dc80436 into trunk Jul 7, 2023
@fluiddot fluiddot deleted the release/1.99.0 branch July 7, 2023 08:11
@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 11, 2023

🟢 Writing Flow (iOS)

Build: 22.8.0.0 (TestFlight)
Device: iPhone 11 (iOS 15.4.1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Undo / Redo - Test Cases

@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 11, 2023

🟢 Unsupported Block Tests (iOS)

Build: 22.8.0.0 (TestFlight)
Device: iPhone 11 (iOS 15.4.1)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 11, 2023

🟢 Release Changes (iOS)

Build: 22.8.0.0 (TestFlight)
Device: iPhone 11 (iOS 15.4.1)

@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 11, 2023

🔴 Functionality Test Suite 5 (iOS)

Build: 22.8.0.0 (TestFlight)
Device: iPhone 11 (iOS 15.4.1)

  • 🔴 I encountered this crash when removing the File block. It's affecting a low volume of users (around 0.01%).

Video block - 1

  • Video block - Insert video from device (failing) - TC001
  • Video block - Close/Re-open post with an ongoing video upload - TC004

Video block - 2

  • Video block - Insert video from device (cancel) - TC002
  • Video block - Close post with an ongoing video upload - TC005
  • Video block - Add Caption - TC003

File block - 1

  • File block - Upload completes successfully from the device library - TC001
  • File block - Insert completes successfully from the WordPress Media library - TC002
  • File block - Upload fails from the device library - TC003
  • File block - Stop the file upload before it completes - TC004

File block - 2

  • File block - Close the post with an ongoing file upload - TC005
  • File block - Replace the selected files - TC006
  • File block - Change the alignment in the File Block - TC007
  • File block - The Link To Block Setting should open - TC008

File block - 3

  • File block - Open link in new tab - TC009
  • File block - Show/hide download button (Block Settings only) - TC010
  • File block - Copy file URL - TC011
  • File block - Close/Re-open post with an ongoing file upload - TC012

Audio block - 1

  • Audio block - Upload completes successfully from the device library - TC001
  • Audio block - Insert completes successfully from the WordPress Media library - TC002

Audio block - 2

  • Audio block - Upload fails from the device library - TC003
  • Audio block - Stop the audio file upload before it completes - TC004

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - TC005
  • Audio block - Replace the selected files - TC006
  • Audio block - Change the alignment in the Audio Block - TC007

Audio block - 4

  • Audio block - Autoplay setting - TC008
  • Audio block - Loop setting - TC009
  • Audio block - Close/Re-open post with an ongoing audio file upload - TC010

Reusable block - 1

  • Reusable block - Add block - TC001
  • Reusable block - Convert to regular blocks - TC002
    • 🔴 I also encountered this crash when detaching a pattern. It didn't happen consistently but I experienced it several times.

Reusable block - 2

  • Reusable block - Deleted reusable block - TC003
  • Reusable block - Recursive block rendering - TC004

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - TC001

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - TC002

@dcalhoun
Copy link
Member

dcalhoun commented Jul 11, 2023

🟢 Writing Flow (Android)

Build: 22.8-rc-1 (Google Play)
Device: Samsung Galaxy S20 5G FE (Android 13)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Undo / Redo - Test Cases

@dcalhoun
Copy link
Member

dcalhoun commented Jul 11, 2023

🟢 Unsupported Block Tests (Android)

Build: 22.8-rc-1 (Google Play)
Device: Samsung Galaxy S20 5G FE (Android 13)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@dcalhoun
Copy link
Member

dcalhoun commented Jul 11, 2023

🟢 Release Changes (Android)

Build: 22.8-rc-1 (Google Play)
Device: Samsung Galaxy S20 5G FE (Android 13)

@dcalhoun
Copy link
Member

dcalhoun commented Jul 11, 2023

🟡 Functionality Test Suite 4 (Android)

Build: 22.8-rc-1 (Google Play)
Device: Samsung Galaxy S20 5G FE (Android 13)

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005

Group - 2

  • Group - Navigation up button works as expected - TC006
  • Group - Navigation down works according to parent-first approach - TC007
  • Group - Cross navigation between blocks works as expected - TC008
  • Group - Check if in DarkMode all components gets proper colors - TC009
  • Group - Check if nested Placeholder block can be replaced - TC010

Buttons - 4

  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC017

Buttons - 5

  • Buttons block - Render theme colors - TC015
  • Buttons block - Settings: Change Button border radius - TC011

Buttons - 7

  • Buttons block - Toolbar link button is active when Button has link - TC018

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

VideoPress - 1

  • VideoPress block - Upload a video - TC001
  • VideoPress block - Add Caption - TC002
  • VideoPress block - Close post with an ongoing video upload - TC004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants