Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.99.0 #5944

Merged
merged 9 commits into from
Jul 7, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions RELEASE-NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Unreleased
---

1.99.0
---
* [*] Rename "Reusable blocks" to "Synced patterns", aligning with the web editor. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5885]
* [**] Fix a crash related to Reanimated when closing the editor [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5938]

Expand Down
16 changes: 7 additions & 9 deletions bundle/android/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
<string name="gutenberg_native_add_video" tools:ignore="UnusedResources">ADD VIDEO</string>
<string name="gutenberg_native_address_settings" tools:ignore="UnusedResources">Address Settings</string>
<string name="gutenberg_native_alt_text" tools:ignore="UnusedResources">Alt Text</string>
<string name="gutenberg_native_alternatively_you_can_detach_and_edit_these_blocks_separately_by" tools:ignore="UnusedResources">Alternatively, you can detach and edit these blocks separately by tapping “Convert to regular blocks”.</string>
<string name="gutenberg_native_alternatively_you_can_detach_and_edit_this_block_separately_by_ta" tools:ignore="UnusedResources">Alternatively, you can detach and edit this block separately by tapping “Convert to regular block”.</string>
<string name="gutenberg_native_alternatively_you_can_detach_and_edit_these_blocks_separately_by" tools:ignore="UnusedResources">Alternatively, you can detach and edit these blocks separately by tapping “Detach patterns”.</string>
<string name="gutenberg_native_alternatively_you_can_detach_and_edit_this_block_separately_by_ta" tools:ignore="UnusedResources">Alternatively, you can detach and edit this block separately by tapping “Detach pattern”.</string>
<string name="gutenberg_native_an_unknown_error_occurred_please_try_again" tools:ignore="UnusedResources">An unknown error occurred. Please try again.</string>
<string name="gutenberg_native_applies_the_setting" tools:ignore="UnusedResources">Applies the setting</string>
<string name="gutenberg_native_arrange_your_content_into_columns_add_call_to_action_buttons_and" tools:ignore="UnusedResources">Arrange your content into columns, add Call to Action buttons, and overlay images with text.</string>
Expand Down Expand Up @@ -159,9 +159,9 @@
<string name="gutenberg_native_edit_using_web_editor" tools:ignore="UnusedResources">Edit using web editor</string>
<string name="gutenberg_native_edit_video" tools:ignore="UnusedResources">Edit video</string>
<!-- translators: %s: name of the host app (e.g. WordPress) -->
<string name="gutenberg_native_editing_reusable_blocks_is_not_yet_supported_on_s_for_android" tools:ignore="UnusedResources">Editing reusable blocks is not yet supported on %s for Android</string>
<string name="gutenberg_native_editing_synced_patterns_is_not_yet_supported_on_s_for_android" tools:ignore="UnusedResources">Editing synced patterns is not yet supported on %s for Android</string>
<!-- translators: %s: name of the host app (e.g. WordPress) -->
<string name="gutenberg_native_editing_reusable_blocks_is_not_yet_supported_on_s_for_ios" tools:ignore="UnusedResources">Editing reusable blocks is not yet supported on %s for iOS</string>
<string name="gutenberg_native_editing_synced_patterns_is_not_yet_supported_on_s_for_ios" tools:ignore="UnusedResources">Editing synced patterns is not yet supported on %s for iOS</string>
<string name="gutenberg_native_embed_block_previews_are_coming_soon" tools:ignore="UnusedResources">Embed block previews are coming soon</string>
<!-- translators: accessibility text. Empty Embed caption. -->
<string name="gutenberg_native_embed_caption_empty" tools:ignore="UnusedResources">Embed caption. Empty</string>
Expand Down Expand Up @@ -209,6 +209,7 @@
<string name="gutenberg_native_line_height" tools:ignore="UnusedResources">Line Height</string>
<string name="gutenberg_native_link_inserted" tools:ignore="UnusedResources">Link inserted</string>
<string name="gutenberg_native_link_rel" tools:ignore="UnusedResources">Link Rel</string>
<string name="gutenberg_native_link_settings" tools:ignore="UnusedResources">Link Settings</string>
<string name="gutenberg_native_link_text" tools:ignore="UnusedResources">Link text</string>
<string name="gutenberg_native_link_to" tools:ignore="UnusedResources">Link To</string>
<string name="gutenberg_native_loading" tools:ignore="UnusedResources">Loading</string>
Expand Down Expand Up @@ -297,7 +298,6 @@ translators: %s: Select control button label e.g. "Button width" -->
<string name="gutenberg_native_replace_image_or_video" tools:ignore="UnusedResources">Replace image or video</string>
<string name="gutenberg_native_replace_video" tools:ignore="UnusedResources">Replace video</string>
<string name="gutenberg_native_retry" tools:ignore="UnusedResources">Retry</string>
<string name="gutenberg_native_reusable" tools:ignore="UnusedResources">Reusable</string>
<string name="gutenberg_native_rich_text_editing" tools:ignore="UnusedResources">Rich text editing</string>
<!-- translators: %s: Block name e.g. "Image block"
translators: Block name. %s: The localized block name -->
Expand All @@ -310,10 +310,8 @@ translators: Block name. %s: The localized block name -->
<string name="gutenberg_native_s_block_options" tools:ignore="UnusedResources">%s block options</string>
<!-- translators: accessibility text for blocks with invalid content. %d: localized block title -->
<string name="gutenberg_native_s_block_this_block_has_invalid_content" tools:ignore="UnusedResources">%s block. This block has invalid content</string>
<!-- translators: %s: name of the reusable block -->
<string name="gutenberg_native_s_converted_to_regular_block" tools:ignore="UnusedResources">%s converted to regular block</string>
<!-- translators: %s: name of the reusable block -->
<string name="gutenberg_native_s_converted_to_regular_blocks" tools:ignore="UnusedResources">%s converted to regular blocks</string>
<!-- translators: %s: name of the synced block -->
<string name="gutenberg_native_s_detached" tools:ignore="UnusedResources">%s detached</string>
<!-- translators: %s: embed block variant's label e.g: "Twitter". -->
<string name="gutenberg_native_s_embed_block_previews_are_coming_soon" tools:ignore="UnusedResources">%s embed block previews are coming soon</string>
<!-- translators: %s: social link name e.g: "Instagram". -->
Expand Down
4,533 changes: 2,269 additions & 2,264 deletions bundle/ios/App.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/App.js.map

Large diffs are not rendered by default.

13 changes: 6 additions & 7 deletions bundle/ios/GutenbergNativeTranslations.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ private func dummy() {
_ = NSLocalizedString("%s block, newly available", comment: "translators: Newly available block name. %s: The localized block name")
_ = NSLocalizedString("%s block. Empty", comment: "translators: accessibility text for the media block empty state. %s: media type")
_ = NSLocalizedString("%s block. This block has invalid content", comment: "translators: accessibility text for blocks with invalid content. %d: localized block title")
_ = NSLocalizedString("%s converted to regular block", comment: "translators: %s: name of the reusable block")
_ = NSLocalizedString("%s converted to regular blocks", comment: "translators: %s: name of the reusable block")
_ = NSLocalizedString("%s detached", comment: "translators: %s: name of the synced block")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All strings related to reusable blocks have been updated due to this expected change.

_ = NSLocalizedString("%s embed block previews are coming soon", comment: "translators: %s: embed block variant's label e.g: \"Twitter\".")
_ = NSLocalizedString("%s has no URL set", comment: "translators: %s: social link name e.g: \"Instagram\".")
_ = NSLocalizedString("%s has URL set", comment: "translators: %s: social link name e.g: \"Instagram\".")
Expand Down Expand Up @@ -46,8 +45,8 @@ private func dummy() {
_ = NSLocalizedString("ADD VIDEO", comment: "")
_ = NSLocalizedString("Address Settings", comment: "")
_ = NSLocalizedString("Alt Text", comment: "")
_ = NSLocalizedString("Alternatively, you can detach and edit these blocks separately by tapping “Convert to regular blocks”.", comment: "")
_ = NSLocalizedString("Alternatively, you can detach and edit this block separately by tapping “Convert to regular block”.", comment: "")
_ = NSLocalizedString("Alternatively, you can detach and edit these blocks separately by tapping “Detach patterns”.", comment: "")
_ = NSLocalizedString("Alternatively, you can detach and edit this block separately by tapping “Detach pattern”.", comment: "")
_ = NSLocalizedString("An unknown error occurred. Please try again.", comment: "")
_ = NSLocalizedString("Applies the setting", comment: "")
_ = NSLocalizedString("Arrange your content into columns, add Call to Action buttons, and overlay images with text.", comment: "")
Expand Down Expand Up @@ -151,8 +150,8 @@ private func dummy() {
_ = NSLocalizedString("Edit media", comment: "")
_ = NSLocalizedString("Edit using web editor", comment: "")
_ = NSLocalizedString("Edit video", comment: "")
_ = NSLocalizedString("Editing reusable blocks is not yet supported on %s for Android", comment: "translators: %s: name of the host app (e.g. WordPress)")
_ = NSLocalizedString("Editing reusable blocks is not yet supported on %s for iOS", comment: "translators: %s: name of the host app (e.g. WordPress)")
_ = NSLocalizedString("Editing synced patterns is not yet supported on %s for Android", comment: "translators: %s: name of the host app (e.g. WordPress)")
_ = NSLocalizedString("Editing synced patterns is not yet supported on %s for iOS", comment: "translators: %s: name of the host app (e.g. WordPress)")
_ = NSLocalizedString("Embed block previews are coming soon", comment: "")
_ = NSLocalizedString("Embed caption. %s", comment: "translators: accessibility text. %s: Embed caption.")
_ = NSLocalizedString("Embed caption. Empty", comment: "translators: accessibility text. Empty Embed caption.")
Expand Down Expand Up @@ -196,6 +195,7 @@ private func dummy() {
_ = NSLocalizedString("Line Height", comment: "")
_ = NSLocalizedString("Link inserted", comment: "")
_ = NSLocalizedString("Link Rel", comment: "")
_ = NSLocalizedString("Link Settings", comment: "")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is no longer used in the web version after this change.

_ = NSLocalizedString("Link text", comment: "")
_ = NSLocalizedString("Link To", comment: "")
_ = NSLocalizedString("Loading", comment: "")
Expand Down Expand Up @@ -272,7 +272,6 @@ private func dummy() {
_ = NSLocalizedString("Replace image or video", comment: "")
_ = NSLocalizedString("Replace video", comment: "")
_ = NSLocalizedString("Retry", comment: "")
_ = NSLocalizedString("Reusable", comment: "")
_ = NSLocalizedString("Rich text editing", comment: "")
_ = NSLocalizedString("Scrollable block menu closed.", comment: "")
_ = NSLocalizedString("Scrollable block menu opened. Select a block.", comment: "")
Expand Down
4 changes: 2 additions & 2 deletions ios-xcframework/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ PODS:
- React-Core
- RNSVG (9.13.6):
- React-Core
- RNTAztecView (1.98.1):
- RNTAztecView (1.99.0):
- React-Core
- WordPress-Aztec-iOS (~> 1.19.8)
- SDWebImage (5.11.1):
Expand Down Expand Up @@ -601,7 +601,7 @@ SPEC CHECKSUMS:
RNReanimated: b5730b32243a35f955202d807ecb43755133ac62
RNScreens: bd1f43d7dfcd435bc11d4ee5c60086717c45a113
RNSVG: 259ef12cbec2591a45fc7c5f09d7aa09e6692533
RNTAztecView: 0cf287757e0879ea9e87e6628851c24f798ba809
RNTAztecView: d96d1e9b317e7bfe153bcb9e82f9287862893579
SDWebImage: a7f831e1a65eb5e285e3fb046a23fcfbf08e696d
SDWebImageWebPCoder: 908b83b6adda48effe7667cd2b7f78c897e5111d
WordPress-Aztec-iOS: 7d11d598f14c82c727c08b56bd35fbeb7dafb504
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gutenberg-mobile",
"version": "1.98.1",
"version": "1.99.0",
"private": true,
"config": {
"jsfiles": "./*.js src/*.js src/**/*.js src/**/**/*.js",
Expand Down