feat: Rename Reusable blocks to Patterns #51704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
Mobile App - i.e. Android or iOS
dcalhoun
force-pushed
the
feat/rename-reusable-blocks-to-patterns
branch
from
10a84f7 to
609f58c
Compare
dcalhoun
added
the
Mobile App - Automation
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 3407ab3f30b193976ea79f37027ba6c8234a3f74. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5334708915
|
|
@glendaviesnz will you please confirm the labels in the screenshots align with your expectations based upon #51144? For context, the unsupported block label is controlled by the block name, so it is somewhat unrelated to the proposed "Synced patterns" changes. gutenberg/packages/block-library/src/missing/edit.native.js Lines 150 to 151 in 3257238 |
Looks correct to me. Thanks. |
geriux
approved these changes
Jun 21, 2023
|
@glendaviesnz is there a likelihood we will revert the web string changes? I saw conversations challenging the web change. If reverting is unlikely, I will merge this before tomorrow's mobile release cut. |
I have only just seen those, maybe it wouldn't hurt to hold off for a few days and see where that discussion goes. |
4 tasks
Align with new web editor terminology: 487f230
Align with new web editor terminology: 487f230
dcalhoun
force-pushed
the
feat/rename-reusable-blocks-to-patterns
branch
from
3407ab3 to
6d179fa
Compare
|
After 7 days, there appears to be little movement on discussions challenging the rename. Elsewhere, work continues to update the naming. Enabling auto-merge for this now. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRS
What?
Rename "Reusable blocks" to "Synced patterns."
Why?
Align with new web editor terminology: 487f230
How?
Update UI text strings and test IDs.
Testing Instructions
without converting the pattern to regular blocks.
Testing Instructions for Keyboard
n/a
Screenshots or screencast