-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gutenberg-mobile release 1.99.0 #21018
Conversation
Generated by 🚫 dangerJS |
RELEASE-NOTES.txt
Outdated
@@ -5,7 +5,8 @@ | |||
* [**] [internal] Make sure synced posts are saved before calling completion block. [#20960] | |||
* [**] [internal] Fix observing Quick Start notifications. [#20997] | |||
* [**] [internal] Fixed an issue that was causing a memory leak in the domain selection flow. [#20813] | |||
|
|||
* [*] [Jetpack-only] Block editor: Rename "Reusable blocks" to "Synced patterns", aligning with the web editor. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5885] | |||
* [**] Block editor: Fix a crash related to Reanimated when closing the editor [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5938] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I mentioned in the iOS PR I was wondering if we should mark this entry as internal, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good idea. Although it's a crash (i.e. something the user notices), I think the release note doesn't give any value to the user as it's hard to reproduce in the app. I'll update it before merging the PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Friendly reminder to update the Gutenberg mobile commit hash to the release tag. 🚀
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
Adding `internal` tag to Reanimated crash entry as it's not guaranteed that would fix it.
Description
This PR incorporates the 1.99.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#5944
Release Submission Checklist
RELEASE-NOTES.txt
if necessary.