Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.99.0 #21018

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jul 6, 2023

Description

This PR incorporates the 1.99.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#5944

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Jul 6, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 6, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@fluiddot fluiddot added this to the 22.8 milestone Jul 6, 2023
@fluiddot fluiddot marked this pull request as ready for review July 6, 2023 12:25
@geriux geriux self-requested a review July 6, 2023 13:24
@@ -5,7 +5,8 @@
* [**] [internal] Make sure synced posts are saved before calling completion block. [#20960]
* [**] [internal] Fix observing Quick Start notifications. [#20997]
* [**] [internal] Fixed an issue that was causing a memory leak in the domain selection flow. [#20813]

* [*] [Jetpack-only] Block editor: Rename "Reusable blocks" to "Synced patterns", aligning with the web editor. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5885]
* [**] Block editor: Fix a crash related to Reanimated when closing the editor [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5938]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I mentioned in the iOS PR I was wondering if we should mark this entry as internal, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good idea. Although it's a crash (i.e. something the user notices), I think the release note doesn't give any value to the user as it's hard to reproduce in the app. I'll update it before merging the PR. Thanks!

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Friendly reminder to update the Gutenberg mobile commit hash to the release tag. 🚀

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 6, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21018-53a7d53
Version22.7
Bundle IDorg.wordpress.alpha
Commit53a7d53
App Center BuildWPiOS - One-Offs #6228
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 6, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21018-53a7d53
Version22.7
Bundle IDcom.jetpack.alpha
Commit53a7d53
App Center Buildjetpack-installable-builds #5255
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

fluiddot added 2 commits July 6, 2023 16:03
Adding `internal` tag to Reanimated crash entry as it's not guaranteed that would fix it.
@fluiddot fluiddot enabled auto-merge July 6, 2023 15:00
@fluiddot fluiddot merged commit eae1bce into trunk Jul 6, 2023
@fluiddot fluiddot deleted the gutenberg/integrate_release_1.99.0 branch July 6, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants