Skip to content

Update support library to 28 #9215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 18, 2019
Merged

Update support library to 28 #9215

merged 8 commits into from
Feb 18, 2019

Conversation

@malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Feb 12, 2019 •
edited
Loading

First step in preparation for #9209 (Migration to AndroidX).

  • I've updated compileSdkVersion and support library version to api 28

  • Some modules required me to explicitly add new dependencies to override versions of transitive dependencies. For example exifinterface:27.1.1 was added as transitive dependency and AS was complaining that having dependencies from both 27.1.1 and 28.0.0 isn't recommended. (I recommend using AS diff tool to compare what has changed, since GitHub doesn't do a very good job)

  • I've fixed places in the code which were targeting old apis. The biggest change is in #1bf1872. Reflection isn't required anymore in order to suppress shift animation on the bottom navigation bar.

  • Some resources we use from the support library have been marked as private -> fixed in da2dc8e

To test:

  • run the app
  • switch tabs in the bottom navigation bar and make sure the animation hasn't changed

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Question: Should we push the changes to the subtrees?
Note: One reviewer should be enough.

@malinajirka malinajirka added this to the 11.9 milestone Feb 12, 2019
@malinajirka
Copy link
Contributor Author

malinajirka commented Feb 12, 2019

@jtreanor It seems we might need to accept an updated license on the CI server. Can you please take a look into it. Thanks!

Failed to install the following Android SDK packages as some licences have not been accepted.
     platforms;android-28 Android SDK Platform 28

@jtreanor
Copy link
Contributor

jtreanor commented Feb 12, 2019

@malinajirka you should be able to update the image used in ‘.circleci/config.yml`. Just change 27 to 28!

@kwonye
Copy link
Contributor

kwonye commented Feb 13, 2019

Thanks for doing this, @malinajirka!

Everything compiles and after doing intensive smoke testing things are running smoothly! That said, there are issues with the tests:

androidTest is failing to compile and in test, QuickStartViewModelTest.testSetDoneTask() is failing.

@kwonye kwonye self-requested a review February 13, 2019 00:24
@malinajirka
Copy link
Contributor Author

malinajirka commented Feb 13, 2019 •
edited
Loading

Thanks @kwonye !!

in test, QuickStartViewModelTest.testSetDoneTask() is failing.

Hmm, it's weird. I've run it locally and I assume CI runs it as well and it works as expected for me.

androidTest is failing to compile

I'll need to look into this. It seems some of the classes we use were deprecated a while ago and they removed them in v28.

@malinajirka
Copy link
Contributor Author

malinajirka commented Feb 18, 2019

@kwonye I've fixed the issue with androidTests. It's ready for another round;). Thanks!

WPScreenshotTest.wPScreenshotTest keeps failing with the following message "Unable to capture screenshot.". However, it's failing even on develop so I assume the issue wasn't introduced in this PR.

kwonye
kwonye approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@kwonye kwonye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malinajirka! Looks great. I created an issue for the failing screenshot tests: #9271

:shipit:

@kwonye kwonye merged commit 88b9e3b into develop Feb 18, 2019
@kwonye kwonye mentioned this pull request Feb 18, 2019
Merged
1 task
@malinajirka malinajirka deleted the feature/update-support-lib-28 branch February 20, 2019 06:30
aforcier added a commit that referenced this pull request Apr 12, 2019
@aforcier
Squashed 'libs/login/' changes from afcb169132..33d3a31871
4cd695b 
33d3a31871 Merge pull request #10 from wordpress-mobile/merge-wpa
b3d3bc5f14 Update style and lint configs
752425f1af Update Gradle wrapper version
3bbe173be8 Merge commit 'e3c231d50ec6bd985404c7aec05502864b4c08d4' into subtree-updates-v3
e81fa900e5 Merge pull request #9215 from wordpress-mobile/feature/update-support-lib-28
c6332e5081 Move default login input row values from layout to class
2ec15519ee Add icon drawable tint color assignment to login input row class
f737b09567 Add icon drawable tint color to login input row attributes
8dd430c3b9 Revert update of targetSdkVersion
f50df670e6 Update supportLib version to 28.0.0
ac2e27a64f Update to Gradle 4.10.3/Android Gradle plugin 3.2.1
64e1ef8889 Reorder repositories in build.gradle to fix Gradle

git-subtree-dir: libs/login
git-subtree-split: 33d3a31871928975215f919dc59e1b71df8b13f6
jd-alexander added a commit that referenced this pull request Jan 12, 2020
@jd-alexander
Squashed 'libs/utils/' changes from 4c6e8c9234..a15de7604a
90001f8 
a15de7604a Merge pull request #25 from wordpress-mobile/deprecate-buggy-date-time-utils-methods
5026dc0904 Mark DateTimeUtils.localDateToUTC and DateTimeUtils.nowUTC as deprecated
58cd5bf239 Mark DateTimeUtils.localDateToUTC and DateTimeUtils.nowUTC as deprecated
4360e5d41f Merge pull request #23 from wordpress-mobile/update-bintray-config
48277981d8 Bump version to 1.23
81f224bd56 Fix Javadoc lint build error when releasing to Bintray
240f2492fa Update Bintray plugin to latest
b6abdcae2a Merge pull request #22 from wordpress-mobile/merge-wpa
8260cdce57 Update style and lint configs
7c08103ff2 Update Gradle wrapper version
9666183e69 Merge commit 'a4a756b60bcbf144ed8527f693c4e974fa6e365d' into subtree-updates-v3
cdeb3eb7f1 Merge pull request #9215 from wordpress-mobile/feature/update-support-lib-28
e8dbd8f404 Revert update of targetSdkVersion
f7014365ea Update supportLib version to 28.0.0
b3ad4c795e Fix low hanging deprecation warnings
b028488305 Remove all instances of LOCATION
bd194edb49 Merge pull request #9114 from wordpress-mobile/issue/8177-applog-testing
e081d898e7 Merge pull request #9044 from wordpress-mobile/gradle-4-10
2ba6f52024 Move fake AppLog(the one for testing) from utils to the main project
3f74b509d0 Create copy of AppLog for unit testing purposes
78d9bfbf13 fixed merge conflict
b3b6665bfd fixed merge conflict
c2fa689153 Update to Gradle 4.10.3/Android Gradle plugin 3.2.1
62b03547dc Merge remote-tracking branch 'origin/develop' into feature/master-site-creation
f55c4c33b1 Removed duplicated dots from image URL
818c1691c7 Rename NewSiteCreationService props
ab051f9083 removed unused imports
0ea8d2aab7 moved unused getDate() method from MediaUtils to getFormattedDateForLastModified() in PostUtils
6e4cecb37b Make the progress of NewSiteCreationService indeterminate
4434057372 Merge branch 'develop' into feature/master-site-creation
e7e89ad67e Fix SiteCreation segment icon color tint
2259033733 Merge branch 'develop' into feature/deep-link-main-activity
0671724495 Merge remote-tracking branch 'origin/develop' into feature/deep-linking-improvements
8f5238e5ef Reorder repositories in build.gradle to fix Gradle
4f18db4eb3 Reorder repositories in build.gradle to fix Gradle
e695cb4a6b Refactor isDeepLinking to be outside MyProfileActivity
d85b6dbb16 Remove unused WPImageGetter
44d63ede88 Add a new type of log tag for pages
5b4a4f09ae Move the logging wrapper class to FluxCUtils for convenience
c7c1ff782a Add Crashlytics logging to make sure we're keeping track of problems uploading media
d12f32a4a7 Remove coroutines and replace them with standard event driven architecture
5580689d26 Remove unused code - ImageUtils.getThumbnail

git-subtree-dir: libs/utils
git-subtree-split: a15de7604a34a9e989884fb84b8c9adfaeeb97b0
wzieba pushed a commit that referenced this pull request Sep 27, 2024
@kwonye
Merge pull request #9215 from wordpress-mobile/feature/update-support…
d9cc2df 
…-lib-28

Update support library to 28
wzieba pushed a commit that referenced this pull request Oct 21, 2024
@kwonye
Merge pull request #9215 from wordpress-mobile/feature/update-support…
e1fb3db 
…-lib-28

Update support library to 28
wzieba pushed a commit that referenced this pull request Oct 21, 2024
@kwonye
Merge pull request #9215 from wordpress-mobile/feature/update-support…
c169ade 
…-lib-28

Update support library to 28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0nko 0nko Awaiting requested review from 0nko

@theck13 theck13 Awaiting requested review from theck13

@nbradbury nbradbury Awaiting requested review from nbradbury

@aforcier aforcier Awaiting requested review from aforcier

1 more reviewer

@kwonye kwonye kwonye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement

Projects

None yet

Milestone

11.9 ❄️

Development

Successfully merging this pull request may close these issues.

4 participants

@malinajirka @jtreanor @kwonye