Add test-friendly AppLog #9114
Merged
Add test-friendly AppLog #9114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Changes make sense to me and tests are passing 👍
|
from me - I see 
Contributor
|
@aforcier I had a look at this on Friday, but since you were more familiar with it, I thought you could review it instead. I guess I should have commented that 🤦♂️ Please feel free to merge it :) |
Contributor
|
|
5 tasks
jd-alexander
added a commit
that referenced
this pull request
Jan 12, 2020
a15de7604a Merge pull request #25 from wordpress-mobile/deprecate-buggy-date-time-utils-methods 5026dc0904 Mark DateTimeUtils.localDateToUTC and DateTimeUtils.nowUTC as deprecated 58cd5bf239 Mark DateTimeUtils.localDateToUTC and DateTimeUtils.nowUTC as deprecated 4360e5d41f Merge pull request #23 from wordpress-mobile/update-bintray-config 48277981d8 Bump version to 1.23 81f224bd56 Fix Javadoc lint build error when releasing to Bintray 240f2492fa Update Bintray plugin to latest b6abdcae2a Merge pull request #22 from wordpress-mobile/merge-wpa 8260cdce57 Update style and lint configs 7c08103ff2 Update Gradle wrapper version 9666183e69 Merge commit 'a4a756b60bcbf144ed8527f693c4e974fa6e365d' into subtree-updates-v3 cdeb3eb7f1 Merge pull request #9215 from wordpress-mobile/feature/update-support-lib-28 e8dbd8f404 Revert update of targetSdkVersion f7014365ea Update supportLib version to 28.0.0 b3ad4c795e Fix low hanging deprecation warnings b028488305 Remove all instances of LOCATION bd194edb49 Merge pull request #9114 from wordpress-mobile/issue/8177-applog-testing e081d898e7 Merge pull request #9044 from wordpress-mobile/gradle-4-10 2ba6f52024 Move fake AppLog(the one for testing) from utils to the main project 3f74b509d0 Create copy of AppLog for unit testing purposes 78d9bfbf13 fixed merge conflict b3b6665bfd fixed merge conflict c2fa689153 Update to Gradle 4.10.3/Android Gradle plugin 3.2.1 62b03547dc Merge remote-tracking branch 'origin/develop' into feature/master-site-creation f55c4c33b1 Removed duplicated dots from image URL 818c1691c7 Rename NewSiteCreationService props ab051f9083 removed unused imports 0ea8d2aab7 moved unused getDate() method from MediaUtils to getFormattedDateForLastModified() in PostUtils 6e4cecb37b Make the progress of NewSiteCreationService indeterminate 4434057372 Merge branch 'develop' into feature/master-site-creation e7e89ad67e Fix SiteCreation segment icon color tint 2259033733 Merge branch 'develop' into feature/deep-link-main-activity 0671724495 Merge remote-tracking branch 'origin/develop' into feature/deep-linking-improvements 8f5238e5ef Reorder repositories in build.gradle to fix Gradle 4f18db4eb3 Reorder repositories in build.gradle to fix Gradle e695cb4a6b Refactor isDeepLinking to be outside MyProfileActivity d85b6dbb16 Remove unused WPImageGetter 44d63ede88 Add a new type of log tag for pages 5b4a4f09ae Move the logging wrapper class to FluxCUtils for convenience c7c1ff782a Add Crashlytics logging to make sure we're keeping track of problems uploading media d12f32a4a7 Remove coroutines and replace them with standard event driven architecture 5580689d26 Remove unused code - ImageUtils.getThumbnail git-subtree-dir: libs/utils git-subtree-split: a15de7604a34a9e989884fb84b8c9adfaeeb97b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8817
Creates a test-friendly copy of AppLog for tests in WPAndroid.
Removes TODO in the NewSiteCreationService and moves the logging into NewSiteCreationServiceManager so the new AppLog can be tested in NewSiteCreationServiceManagerTest.
To test:
Note: Update TODO in #9079 after merge. Thanks!
Update release notes:
RELEASE-NOTES.txt.