Squashed 'libs/login/' changes from afcb169132..33d3a31871

33d3a31871 Merge pull request #10 from wordpress-mobile/merge-wpa
b3d3bc5f14 Update style and lint configs
752425f1af Update Gradle wrapper version
3bbe173be8 Merge commit 'e3c231d50ec6bd985404c7aec05502864b4c08d4' into subtree-updates-v3
e81fa900e5 Merge pull request #9215 from wordpress-mobile/feature/update-support-lib-28
c6332e5081 Move default login input row values from layout to class
2ec15519ee Add icon drawable tint color assignment to login input row class
f737b09567 Add icon drawable tint color to login input row attributes
8dd430c3b9 Revert update of targetSdkVersion
f50df670e6 Update supportLib version to 28.0.0
ac2e27a64f Update to Gradle 4.10.3/Android Gradle plugin 3.2.1
64e1ef8889 Reorder repositories in build.gradle to fix Gradle

git-subtree-dir: libs/login
git-subtree-split: 33d3a31871928975215f919dc59e1b71df8b13f6

Author: aforcier

.idea/checkstyle-idea.xml

@@ -1,10 +1,10 @@
 buildscript {
     repositories {
-        jcenter()
         google()
+        jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.3'
+        classpath 'com.android.tools.build:gradle:3.2.1'
     }
 }
 
@@ -17,8 +17,8 @@ repositories {
 }
 
 android {
-    compileSdkVersion 27
-    buildToolsVersion "27.0.3"
+    compileSdkVersion 28
+    buildToolsVersion "28.0.3"
 
     defaultConfig {
         minSdkVersion 16
@@ -35,8 +35,12 @@ dependencies {
         exclude group: "com.mcxiaoke.volley"
     }
 
-    implementation 'com.android.support:appcompat-v7:27.1.1'
-    implementation 'com.android.support:design:27.1.1'
+    implementation 'com.android.support:appcompat-v7:28.0.0'
+    implementation 'com.android.support:animated-vector-drawable:28.0.0'
+    implementation 'com.android.support:support-media-compat:28.0.0'
+    implementation 'com.android.support:support-v13:28.0.0'
+    implementation 'com.android.support:gridlayout-v7:28.0.0'
+    implementation 'com.android.support:design:28.0.0'
 
     api 'com.google.android.gms:play-services-auth:15.0.1'
 

.idea/codeStyles/Project.xml

@@ -1,13 +1,18 @@
 package org.wordpress.android.login.widgets;
 
 import android.content.Context;
+import android.content.res.ColorStateList;
 import android.content.res.TypedArray;
+import android.graphics.PorterDuff;
+import android.graphics.drawable.Drawable;
 import android.os.Build;
 import android.os.Bundle;
 import android.os.Parcel;
 import android.os.Parcelable;
 import android.support.annotation.Nullable;
 import android.support.design.widget.TextInputLayout;
+import android.support.v4.content.ContextCompat;
+import android.support.v4.graphics.drawable.DrawableCompat;
 import android.text.TextWatcher;
 import android.util.AttributeSet;
 import android.util.SparseArray;
@@ -70,7 +75,21 @@ private void init(Context context, AttributeSet attrs) {
 
             try {
                 if (a.hasValue(R.styleable.wpLoginInputRow_wpIconDrawable)) {
-                    mIcon.setImageResource(a.getResourceId(R.styleable.wpLoginInputRow_wpIconDrawable, 0));
+                    int iconResId = a.getResourceId(R.styleable.wpLoginInputRow_wpIconDrawable,
+                            R.drawable.ic_user_grey_24dp);
+                    int tintResId = a.getResourceId(R.styleable.wpLoginInputRow_wpIconDrawableTint,
+                            R.color.login_input_icon_color);
+
+                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+                        mIcon.setImageTintList(ColorStateList.valueOf(ContextCompat.getColor(context, tintResId)));
+                        mIcon.setImageResource(iconResId);
+                    } else {
+                        Drawable drawable = context.getResources().getDrawable(iconResId);
+                        DrawableCompat.setTint(drawable, context.getResources().getColor(tintResId));
+                        DrawableCompat.setTintMode(drawable, PorterDuff.Mode.SRC_IN);
+                        mIcon.setImageDrawable(drawable);
+                    }
+
                     mIcon.setVisibility(View.VISIBLE);
                 } else {
                     mIcon.setVisibility(View.GONE);

WordPressLoginFlow/build.gradle

@@ -15,8 +15,8 @@
         android:layout_marginRight="@dimen/margin_extra_large"
         android:layout_marginEnd="@dimen/margin_extra_large"
         android:importantForAccessibility="no"
-        android:tint="@color/login_input_icon_color"
-        app:srcCompat="@drawable/ic_user_grey_24dp"/>
+        tools:srcCompat="@drawable/ic_user_grey_24dp"
+        tools:tint="@color/login_input_icon_color"/>
 
     <org.wordpress.android.util.widgets.WPTextInputLayout
         android:layout_centerVertical="true"

WordPressLoginFlow/src/main/java/org/wordpress/android/login/widgets/WPLoginInputRow.java

@@ -6,6 +6,7 @@
     -->
     <declare-styleable name="wpLoginInputRow">
         <attr name="wpIconDrawable" format="reference"/>
+        <attr name="wpIconDrawableTint" format="color"/>
         <attr name="android:inputType" />
         <attr name="android:hint" />
         <attr name="android:imeOptions" />

WordPressLoginFlow/src/main/res/layout/login_input_row.xml

@@ -34,15 +34,6 @@
 
     <!-- Miscellaneous other checks.                   -->
     <!-- See http://checkstyle.sf.net/config_misc.html -->
-    <module name="RegexpSingleline">
-       <property name="format" value="\s+$"/>
-       <property name="minimum" value="0"/>
-       <property name="maximum" value="0"/>
-       <property name="message" value="Line has trailing spaces."/>
-       <property name="severity" value="error"/>
-    </module>
-
-
     <module name="RegexpMultiline">
       <property name="format"
                 value="(\n|\r\n)[\t ]*(\n|\r\n)[\t ]*\}"/>
@@ -154,7 +145,9 @@
         <!-- Checks for imports                              -->
         <!-- See http://checkstyle.sf.net/config_import.html -->
         <module name="AvoidStarImport"/>
-        <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
+        <module name="IllegalImport">
+            <property name="illegalClasses" value="android.app.Fragment"/>
+        </module>
         <module name="RedundantImport"/>
         <module name="UnusedImports">
             <property name="processJavadoc" value="true"/>
@@ -181,6 +174,7 @@
           <property name="tokens" value="METHOD_DEF"/>
           <!-- TODO: We should set this value around 40 or 50 -->
           <property name="max" value="200"/>
+          <property name="severity" value="warning"/>
         </module>
 
         <!-- Checks for whitespace                               -->

WordPressLoginFlow/src/main/res/values/attrs.xml

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.3-all.zip