feat: create password protected guest link #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invite links [WPB-1531] (#1950) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com>
* CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
…e/epic # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/event/EventMapper.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/receiver/ConversationEventReceiver.kt # persistence/src/commonMain/db_user/migrations/53.sqm
* CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
* CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test * feat: propagate if a guest link is password protected --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
MohamadJaara
requested review from
typfel,
alexandreferris,
vitorhugods,
Garzas and
ohassine
…e/epic # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/event/EventMapper.kt # network/src/commonMain/kotlin/com/wire/kalium/network/api/v4/authenticated/ConversationApiV4.kt # persistence/src/commonMain/db_user/migrations/54.sqm
github-actions
bot
added
🚨 Potential breaking changes
type: feature ✨
👕 size: XXL
labels
Codecov Report
@@ Coverage Diff @@
## develop #1986 +/- ##
=============================================
+ Coverage 58.16% 58.26% +0.09%
Complexity 23 23
=============================================
Files 970 975 +5
Lines 37144 37268 +124
Branches 3408 3416 +8
=============================================
+ Hits 21605 21714 +109
- Misses 14070 14084 +14
- Partials 1469 1470 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
alexandreferris
approved these changes
Aug 16, 2023
saleniuk
approved these changes
Aug 18, 2023
MohamadJaara
deleted the
feat/create-password-protected-invite-code/epic
branch
echoes-hq
bot
added
the
echoes: features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
creating a password protected guest link
Solutions
this PR contains the following changes.
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.