-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: propagate if a guest link is password protected #1985
Conversation
…eat/handle-code-update-and-delete-event # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt
…r/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com>
…r/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com>
…rd-protected-conv-invite-link # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/event/EventMapper.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/receiver/ConversationEventReceiver.kt # network/src/commonMain/kotlin/com/wire/kalium/network/api/v4/authenticated/ConversationApiV4.kt # persistence/src/commonMain/db_user/migrations/53.sqm
…eat/create-password-protected-conv-invite-link # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationGroupRepository.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/receiver/ConversationEventReceiver.kt # network/src/commonMain/kotlin/com/wire/kalium/network/api/base/authenticated/notification/EventContentDTO.kt
Codecov Report
@@ Coverage Diff @@
## feat/create-password-protected-conv-invite-link #1985 +/- ##
=====================================================================================
+ Coverage 58.12% 58.23% +0.11%
Complexity 23 23
=====================================================================================
Files 969 971 +2
Lines 36781 36795 +14
Branches 3356 3356
=====================================================================================
+ Hits 21380 21429 +49
+ Misses 13957 13921 -36
- Partials 1444 1445 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
…eat/create-password-protected-invite-code/return-if-the-guest-link-is-password-protected-when-observing
24ede05
into
feat/create-password-protected-invite-code/epic
* feat: add use case to decide if a user can create password protected invite links [WPB-1531] (#1950) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> * feat: handle code update and delete events (#1960) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: create password protected conv invite link (#1982) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: propagate if a guest link is password protected (#1985) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test * feat: propagate if a guest link is password protected --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * merge issue --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
* feat: add use case to decide if a user can create password protected invite links [WPB-1531] (#1950) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> * feat: handle code update and delete events (#1960) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: create password protected conv invite link (#1982) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: propagate if a guest link is password protected (#1985) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test * feat: propagate if a guest link is password protected --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * merge issue * feat: implement cert pinning * detekt * detekt * feat: add cert pinning config * detekt * fix CLI and test service * test * address PR comments * add cert pinning config as val instead of fun --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
observe conversation code need to include info about the code if it is password protected or not
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.