feat: add use case to decide if a user can create password protected invite links [WPB-1531] #1950

MohamadJaara · 2023-08-03T15:29:31Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

WPB-1531
password protected guest links are supported on api v4+

Solutions

add use case to check the user api version

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

alexandreferris

👌🏻 just a tiny comment

...re/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt

alexandreferris · 2023-08-03T15:39:28Z

logic/src/commonMain/kotlin/com/wire/kalium/logic/configuration/server/ServerConfig.kt

+    data object New : CommonApiVersionType {
+        override val version: Int
+            get() = NEW_API_VERSION_NUMBER
+    }
+
+    data object Unknown : CommonApiVersionType {
+        override val version: Int
+            get() = UNKNOWN_API_VERSION_NUMBER
+    }


…ersation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com>

github-actions · 2023-08-03T15:51:14Z

Unit Test Results

  300 files - 116   300 suites - 116 12s ⏱️ - 1m 48s
1 554 tests - 671 1 521 ✔️ - 606 33 💤 - 65 0 ❌ ±0

Results for commit 50b235c. ± Comparison against base commit c02db2a.

♻️ This comment has been updated with latest results.

codecov-commenter · 2023-08-03T16:07:03Z

Codecov Report

Merging #1950 (389be5c) into develop (250cfb9) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

@@              Coverage Diff              @@
##             develop    #1950      +/-   ##
=============================================
- Coverage      56.36%   56.35%   -0.01%     
  Complexity        35       35              
=============================================
  Files            998      999       +1     
  Lines          37329    37340      +11     
  Branches        3392     3393       +1     
=============================================
+ Hits           21040    21044       +4     
- Misses         14857    14865       +8     
+ Partials        1432     1431       -1

Files Changed	Coverage Δ
...um/logic/feature/conversation/ConversationScope.kt	`0.00% <0.00%> (ø)`
...roomlink/CanCreatePasswordProtectedLinksUseCase.kt	`87.50% <87.50%> (ø)`
.../kalium/logic/configuration/server/ServerConfig.kt	`62.28% <100.00%> (-0.17%)`	⬇️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250cfb9...389be5c. Read the comment docs.

…ssword-protected-guest-links

datadog-wireapp · 2023-08-04T10:19:54Z

Datadog Report

All test runs 904356f 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Branch View
`kalium-ios`	0	0	0	1517	33	10.09s	Link
`kalium-jvm`	0	0	0	2126	98	5m 7s	Link

…eat/use-case-for-is-a-user-can-create-password-protected-guest-links

* feat: add use case to decide if a user can create password protected invite links [WPB-1531] (#1950) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> * feat: handle code update and delete events (#1960) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: create password protected conv invite link (#1982) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: propagate if a guest link is password protected (#1985) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test * feat: propagate if a guest link is password protected --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * merge issue --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>

* feat: add use case to decide if a user can create password protected invite links [WPB-1531] (#1950) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> * feat: handle code update and delete events (#1960) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: create password protected conv invite link (#1982) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: propagate if a guest link is password protected (#1985) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test * feat: propagate if a guest link is password protected --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * merge issue * feat: implement cert pinning * detekt * detekt * feat: add cert pinning config * detekt * fix CLI and test service * test * address PR comments * add cert pinning config as val instead of fun --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>

CanCreatePasswordProtectedLinksUseCase

450cd7e

github-actions bot assigned MohamadJaara Aug 3, 2023

github-actions bot added 🚨 Potential breaking changes type: feature ✨ 👕 size: M Fix PR Title 🤦‍♂️ and removed Fix PR Title 🤦‍♂️ labels Aug 3, 2023

MohamadJaara added 2 commits August 3, 2023 17:31

docs

6de5bf0

detekt

85e0067

github-actions bot removed the Fix PR Title 🤦‍♂️ label Aug 3, 2023

test

71f615c

MohamadJaara requested review from typfel, alexandreferris, vitorhugods, a team, gongracr and ohassine and removed request for a team August 3, 2023 15:36

alexandreferris approved these changes Aug 3, 2023

View reviewed changes

Update logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conv…

e29ac79

…ersation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com>

ohassine approved these changes Aug 4, 2023

View reviewed changes

Merge branch 'develop' into feat/use-case-for-is-a-user-can-create-pa…

389be5c

…ssword-protected-guest-links

MohamadJaara changed the base branch from develop to feat/create-password-protected-invite-code/epic August 5, 2023 16:35

Merge branch 'feat/create-password-protected-invite-code/epic' into f…

50b235c

…eat/use-case-for-is-a-user-can-create-password-protected-guest-links

MohamadJaara merged commit dc7be59 into feat/create-password-protected-invite-code/epic Aug 5, 2023
2 checks passed

MohamadJaara deleted the feat/use-case-for-is-a-user-can-create-password-protected-guest-links branch August 5, 2023 16:36

MohamadJaara mentioned this pull request Aug 15, 2023

feat: create password protected guest link #1986

Merged

6 tasks

echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Jul 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add use case to decide if a user can create password protected invite links [WPB-1531] #1950

feat: add use case to decide if a user can create password protected invite links [WPB-1531] #1950

MohamadJaara commented Aug 3, 2023 •

edited by jira bot

Loading

alexandreferris left a comment

alexandreferris Aug 3, 2023

github-actions bot commented Aug 3, 2023 •

edited

Loading

codecov-commenter commented Aug 3, 2023 •

edited

Loading

datadog-wireapp bot commented Aug 4, 2023

feat: add use case to decide if a user can create password protected invite links [WPB-1531] #1950

feat: add use case to decide if a user can create password protected invite links [WPB-1531] #1950

Conversation

MohamadJaara commented Aug 3, 2023 • edited by jira bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

alexandreferris left a comment

Choose a reason for hiding this comment

alexandreferris Aug 3, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 3, 2023 • edited Loading

Unit Test Results

codecov-commenter commented Aug 3, 2023 • edited Loading

Codecov Report

datadog-wireapp bot commented Aug 4, 2023

Datadog Report

MohamadJaara commented Aug 3, 2023 •

edited by jira bot

Loading

github-actions bot commented Aug 3, 2023 •

edited

Loading

codecov-commenter commented Aug 3, 2023 •

edited

Loading