feat: handle code update and delete events #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/handle-code-update-and-delete-event # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt
MohamadJaara
force-pushed
the
feat/handle-code-update-and-delete-event
branch
from
3980597
to
2afac1a
Compare
MohamadJaara
commented
Aug 5, 2023
Comment on lines
+318
to
+320
| // TODO: set the correct value for is passwordProtected | ||
| it.data?.let { data -> conversationDAO.updateGuestRoomLink(conversationId.toDao(), data.uri, false) } | ||
| it.uri?.let { link -> conversationDAO.updateGuestRoomLink(conversationId.toDao(), link, false) } |
There was a problem hiding this comment.
The model returned from the remote request needs to be changed and will be part of the next PR
Datadog ReportAll test runs ❌ 2 Total Test Services: 1 Failed, 0 with New Flaky, 1 Passed Test Services
❌ Failed Tests (7)
|
MohamadJaara
requested review from
a team and
typfel
and removed request for
a team
...src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt
Outdated
Show resolved
Hide resolved
...src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt
Outdated
Show resolved
Hide resolved
.../commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt
Outdated
Show resolved
Hide resolved
…r/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com>
…r/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com>
alexandreferris
approved these changes
Aug 7, 2023
MohamadJaara
merged commit abd6cdf
into
feat/create-password-protected-invite-code/epic
12 checks passed
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
* feat: add use case to decide if a user can create password protected invite links [WPB-1531] (#1950) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> * feat: handle code update and delete events (#1960) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: create password protected conv invite link (#1982) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: propagate if a guest link is password protected (#1985) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test * feat: propagate if a guest link is password protected --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * merge issue --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* feat: add use case to decide if a user can create password protected invite links [WPB-1531] (#1950) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/guestroomlink/CanCreatePasswordProtectedLinksUseCase.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> * feat: handle code update and delete events (#1960) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: create password protected conv invite link (#1982) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * feat: propagate if a guest link is password protected (#1985) * CanCreatePasswordProtectedLinksUseCase * docs * detekt * test * feat: handle code update and delete event * test * code delete code * inject handler * detekt * add fake value for is password protected * add has password to event DTO * missing any * fix test * detekt * db migration * typo in db migration * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeDeletedHandler.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/conversation/CodeUpdateHandlerTest.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> * file name * fix(tests): fix e2ei mock order timing * support api v4 for password protected invite links * fix: unresolved reference * fix merge issues * feat: generate password protected guest link * add test * detekt * fix test * feat: propagate if a guest link is password protected --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com> * merge issue * feat: implement cert pinning * detekt * detekt * feat: add cert pinning config * detekt * fix CLI and test service * test * address PR comments * add cert pinning config as val instead of fun --------- Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com> Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Conversation code update and delete events are not handled
Solutions
map and handle the events
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.