Skip to content

RSDK-10227 - Propagate env vars for local modules #4853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Conversation

cheukt
Copy link
Member

@cheukt cheukt commented Mar 13, 2025

did a dumb thing and was making a copy (since we're passing by value) before modifying, so we end up losing the modifications

@cheukt cheukt requested a review from stuqdog March 13, 2025 20:36
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Mar 13, 2025
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for digging and putting this together!

@cheukt cheukt merged commit fb5e96d into main Mar 14, 2025
17 checks passed
@cheukt cheukt deleted the fix-merge-env branch March 14, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants