RSDK-10208 - create app client from env vars #874
Merged
+65
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
requested changes
Mar 14, 2025
src/viam/app/viam_client.py
Outdated
| @@ -24,14 +25,46 @@ class ViamClient: | |||
| ViamClient.create_from_dial_options(...) | |||
| """ | |||
|
|
|||
| @classmethod | |||
| async def create_from_env_vars(cls, dial_options: Optional[DialOptions] = None, app_url: Optional[str] = None) -> Self: | |||
| """Create `ViamClient` using credentials set by a module. | |||
There was a problem hiding this comment.
I think instead of "set by a module" maybe say "using credentials set in the environment as VIAM_API_KEY and VIAM_API_KEY_ID"
njooma
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on release of viamrobotics/rdk#4853, though tested against those changes locally and was able to create a
ViamClientsuccessfully.