Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated test names #1

Open
wants to merge 588 commits into
base: main
Choose a base branch
from
Open

Fix duplicated test names #1

wants to merge 588 commits into from

Conversation

unseen1980
Copy link
Owner

Some tests had the same test descriptions.

@unseen1980 unseen1980 force-pushed the duplicated-test-names branch 2 times, most recently from 70ce115 to 1c293cb Compare August 12, 2024 11:04
RedYetiDev and others added 26 commits September 6, 2024 17:31
@RedYetiDev
build: don't store eslint locally
437e168 
PR-URL: nodejs#54231
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@alexandre-abrioux
doc: clarify --max-old-space-size and --max-semi-space-size units
bec8089 
PR-URL: nodejs#54477
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@santigimeno
test: refactor fs-watch tests due to macOS issue
b345118 
In `macOS`, fsevents generated immediately before start watching may
leak into the event callback. See: nodejs#54450
for an explanation. This might be fixed at some point in `libuv` though
it may take some time (see: libuv/libuv#3866).
This commit comes in anticipation of the soon-to-be-released
`libuv@1.49.0` which was making these tests very flaky.

PR-URL: nodejs#54498
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@aduh95
test: fix test-process-load-env-file when path contains '
a75e3df 
If the repo is cloned on a path that contains a quote, the test should
not fail.

PR-URL: nodejs#54511
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jazelly @targos
buffer: fix out of range for toString
1c67899 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#54553
Fixes: nodejs#52298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@jazelly @jakecastelli
lib: convert signals to array before validation
973144b 
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: nodejs#54714
Fixes: nodejs#54674
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS @nodejs-github-bot
benchmark: add buffer.isUtf8 bench
00291ea 
PR-URL: nodejs#54740
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS @nodejs-github-bot
benchmark: add buffer.isAscii benchmark
2f8d81e 
PR-URL: nodejs#54740
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RedYetiDev
meta: add Windows ARM64 to flaky-tests list
c046c9b 
PR-URL: nodejs#54693
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@JLHwung
crypto: reject dh,x25519,x448 in {Sign,Verify}Final
18101d8 
Fixes: nodejs#53742
PR-URL: nodejs#53774
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@tniessen
doc: fix typo in recognizing-contributors
f061210 
PR-URL: nodejs#54822
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@nodejs-github-bot
deps: update cjs-module-lexer to 1.4.0
01bf4a1 
PR-URL: nodejs#54713
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@guybedford
doc: mark --conditions CLI flag as stable
c813de4 
PR-URL: nodejs#54209
Reviewed-By: James M Snell <jasnell@gmail.com>
@anonrig @jasnell
test: set test-debugger-heap-profiler as flaky
c4c580b 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-performance-function as flaky
866d32f 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-runner-watch-mode-complex as flaky
affd1ce 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-http2-large-file as flaky
9c6d6de 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-esm-loader-hooks-inspect-wait as flaky
de23827 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-async-context-frame as flaky
407b61c 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-writewrap as flaky
e5c8978 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-sqlite-statement-sync as flaky
8ed9d54 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-runner-run-watch as flaky
f26c9bd 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-fs-utimes as flaky
cfb128a 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-macos-app-sandbox as flaky
b002b62 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-single-executable-application-empty as flaky
67ccb3a 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@anonrig @jasnell
test: set test-http-server-request-timeouts-mixed as flaky
c45b7ec 
PR-URL: nodejs#54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
jasnell and others added 29 commits September 23, 2024 04:20
@jasnell
src: move evp stuff to ncrypto
c4681d5 
PR-URL: nodejs#54911
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jakecastelli
benchmark: add webstorage benchmark
96ec7ee 
PR-URL: nodejs#55040
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@panva
crypto: ensure invalid SubtleCrypto JWK data import results in DataError
b64006c 
PR-URL: nodejs#55041
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RedYetiDev
process: remove process.assert
c237eab 
PR-URL: nodejs#55035
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@anonrig
lib: remove lib/internal/idna.js
76edde5 
PR-URL: nodejs#55050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RedYetiDev
doc: add note about --expose-internals
f20c42e 
PR-URL: nodejs#52861
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RedYetiDev
tools: remove redudant code from eslint require rule
f43424a 
PR-URL: nodejs#54892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@anonrig
string_decoder: refactor encoding validation
ffe0dc5 
PR-URL: nodejs#54957
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@lpinca
test: deflake test-inspector-strip-types
3c5ceff 
Use the `NodeRuntime.waitingForDebugger` event.

Refs: nodejs#51560
PR-URL: nodejs#55058
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@nodejs-github-bot
deps: update acorn-walk to 8.3.4
a6ece28 
PR-URL: nodejs#54950
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@pmarchini
test: remove interval and give more time to unsync
02e8972 
PR-URL: nodejs#55006
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@RedYetiDev
build: update ruff and add lint-py-fix
a1cd3c8 
PR-URL: nodejs#54410
Reviewed-By: Christian Clauss <cclauss@me.com>
@abmusse
doc: add abmusse to collaborators
b8493a5 
PR-URL: nodejs#55086
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@luketaher
perf_hooks: add missing type argument to getEntriesByName
04750af 
Fixes: nodejs#54766
PR-URL: nodejs#54767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RedYetiDev
lib: prefer optional chaining
574f2dd 
PR-URL: nodejs#55045
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@RedYetiDev
tty: fix links for terminal colors
29a4fcf 
PR-URL: nodejs#54596
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RedYetiDev
build: add more information to Makefile help
b2c42db 
PR-URL: nodejs#53381
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos
tools: unlock versions of irrelevant DB deps
0257102 
This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.

PR-URL: nodejs#55042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jazelly
stream: set stream prototype to closest transferable superclass
0e52836 
PR-URL: nodejs#55067
Fixes: nodejs#54603
Refs: nodejs#50107
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@zcbenz
src: do not call path.back() when it is empty
773e7c6 
PR-URL: nodejs#55072
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@joyeecheung
module: implement the "module-sync" exports condition
0b9249e 
This patch implements a "module-sync" exports condition
for packages to supply a sycnrhonous ES module to the
Node.js module loader, no matter it's being required
or imported. This is similar to the "module" condition
that bundlers have been using to support `require(esm)`
in Node.js, and allows dual-package authors to opt into
ESM-first only newer versions of Node.js that supports
require(esm) while avoiding the dual-package hazard.

```json
{
  "type": "module",
  "exports": {
    "node": {
      // On new version of Node.js, both require() and import get
      // the ESM version
      "module-sync": "./index.js",
      // On older version of Node.js, where "module" and
      // require(esm) are not supported, use the transpiled CJS version
      // to avoid dual-package hazard. Library authors can decide
      // to drop support for older versions of Node.js when they think
      // it's time.
      "default": "./dist/index.cjs"
    },
    // On any other environment, use the ESM version.
    "default": "./index.js"
  }
}
```

We end up implementing a condition with a different name
instead of reusing "module", because existing code in the
ecosystem using the "module" condition sometimes also expect
the module resolution for these ESM files to work in CJS
style, which is supported by bundlers, but the native
Node.js loader has intentionally made ESM resolution
different from CJS resolution (e.g. forbidding `import
'./noext'` or `import './directory'`), so it would be
semver-major to implement a `"module"` condition
without implementing the forbidden ESM resolution rules.
For now, this just implments a new condition as semver-minor
so it can be backported to older LTS.

Refs: https://webpack.js.org/guides/package-exports/#target-environment-independent-packages
PR-URL: nodejs#54648
Fixes: nodejs#52173
Refs: https://github.com/joyeecheung/test-module-condition
Refs: nodejs#52697
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RedYetiDev
repl: catch \v and \r in new-line detection
c6d20a0 
PR-URL: nodejs#54512
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RedYetiDev
lib, tools: remove duplicate requires
5c22d19 
PR-URL: nodejs#54987
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@lpinca
Revert "test: mark test-fs-watch-non-recursive flaky on Windows"
61ad74f 
This reverts commit 2a871df.

It has been almost three years since the test was marked flaky. Remove
the unstable designation to see if the problem persists on Windows.

Fixes: nodejs#40728
PR-URL: nodejs#55079
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@Renegade334
doc: correct cleanup option in stream.(promises.)finished
7f48081 
PR-URL: nodejs#55043
Refs: nodejs#44862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@NathanBaulch
lib: fix typos
4c04535 
PR-URL: nodejs#55065
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@anonrig
src: update clang-tidy and focus on modernization
6fb9f56 
PR-URL: nodejs#53757
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@unseen1980 @aduh95
test: remove duplicated test descriptions
b4b04ce
@unseen1980 @aduh95
fixup! test: remove duplicated test descriptions
66300fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.