process: remove `process.assert` #55035

RedYetiDev · 2024-09-20T22:10:14Z

This feature was never documented, and has been runtime deprecated since v10. Why not remove it entirely?

nodejs-github-bot · 2024-09-20T22:10:18Z

Review requested:

@nodejs/startup

RedYetiDev · 2024-09-20T22:20:02Z

aduh95 · 2024-09-20T22:22:25Z

Can you update the commit message so it complies with our guidelines? "EoL" is not a verb in the imperative form. I suggest process. remove `process.assert` .

codecov · 2024-09-20T23:57:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (8b8fc53) to head (c7b180f).
Report is 40 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55035      +/-   ##
==========================================
- Coverage   88.23%   88.23%   -0.01%     
==========================================
  Files         652      652              
  Lines      183855   183841      -14     
  Branches    35856    35852       -4     
==========================================
- Hits       162227   162204      -23     
- Misses      14909    14913       +4     
- Partials     6719     6724       +5

Files with missing lines	Coverage Δ
lib/internal/bootstrap/node.js	`99.77% <100.00%> (-0.01%)`	⬇️
lib/internal/process/per_thread.js	`99.30% <ø> (-0.01%)`	⬇️

... and 27 files with indirect coverage changes

benjamingr

It would be prudent to run CITGM before landing this

nodejs-github-bot · 2024-09-21T15:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62623/ 💚

RedYetiDev · 2024-09-21T21:18:12Z

CI is passing - but as @benjamingr said above, a CITGM would be nice

marco-ippolito · 2024-09-23T08:07:18Z

CITGM https://ci.nodejs.org/job/citgm-smoker/3476/

RedYetiDev · 2024-09-23T11:45:08Z

None of the CITGM failures look related to this change (mostly disk space issues).

mcollina

lgtm

nodejs-github-bot · 2024-09-23T16:29:25Z

Landed in c237eab

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: TBD

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: #55338

PR-URL: nodejs#55035 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) nodejs#53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) nodejs#54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) nodejs#47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) nodejs#54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) nodejs#54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) nodejs#54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) nodejs#53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) nodejs#45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) nodejs#53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) nodejs#54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) nodejs#52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) nodejs#52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) nodejs#52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) nodejs#52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) nodejs#55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) nodejs#53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) nodejs#52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) nodejs#54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) nodejs#54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) nodejs#54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) nodejs#54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) nodejs#54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) nodejs#53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) nodejs#54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) nodejs#49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) nodejs#51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) nodejs#54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) nodejs#54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) nodejs#53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) nodejs#54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) nodejs#54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) nodejs#55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) nodejs#54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) nodejs#54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) nodejs#54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) nodejs#54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) nodejs#53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) nodejs#52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) nodejs#53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) nodejs#54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) nodejs#54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) nodejs#54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) nodejs#54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) nodejs#52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) nodejs#46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) nodejs#52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) nodejs#54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) nodejs#54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) nodejs#54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) nodejs#54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) nodejs#52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) nodejs#52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) nodejs#55020 PR-URL: nodejs#55338

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Sep 20, 2024

RedYetiDev force-pushed the eol-process-assert branch 2 times, most recently from f855179 to a235cb5 Compare September 20, 2024 22:17

RedYetiDev changed the title ~~domain: eol deprecate process.assert~~ process: eol deprecate process.assert Sep 20, 2024

RedYetiDev force-pushed the eol-process-assert branch from a235cb5 to 588348a Compare September 20, 2024 22:17

RedYetiDev added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Sep 20, 2024

process: remove process.assert

c7b180f

RedYetiDev force-pushed the eol-process-assert branch from 588348a to c7b180f Compare September 20, 2024 22:24

RedYetiDev changed the title ~~process: eol deprecate process.assert~~ process: remove process.assert Sep 20, 2024

anonrig approved these changes Sep 20, 2024

View reviewed changes

jakecastelli approved these changes Sep 21, 2024

View reviewed changes

benjamingr approved these changes Sep 21, 2024

View reviewed changes

RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 21, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024

jasnell approved these changes Sep 21, 2024

View reviewed changes

RafaelGSS approved these changes Sep 21, 2024

View reviewed changes

aduh95 added the needs-citgm PRs that need a CITGM CI run. label Sep 22, 2024

atlowChemi approved these changes Sep 22, 2024

View reviewed changes

marco-ippolito approved these changes Sep 23, 2024

View reviewed changes

mcollina approved these changes Sep 23, 2024

View reviewed changes

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2024

nodejs-github-bot merged commit c237eab into nodejs:main Sep 23, 2024
61 checks passed

RafaelGSS mentioned this pull request Oct 9, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

process: remove `process.assert` #55035

process: remove `process.assert` #55035

RedYetiDev commented Sep 20, 2024

nodejs-github-bot commented Sep 20, 2024

RedYetiDev commented Sep 20, 2024

aduh95 commented Sep 20, 2024

codecov bot commented Sep 20, 2024 •

edited

Loading

benjamingr left a comment

nodejs-github-bot commented Sep 21, 2024 •

edited by jasnell

Loading

RedYetiDev commented Sep 21, 2024 •

edited

Loading

marco-ippolito commented Sep 23, 2024

RedYetiDev commented Sep 23, 2024

mcollina left a comment

nodejs-github-bot commented Sep 23, 2024

process: remove process.assert #55035

process: remove process.assert #55035

Conversation

RedYetiDev commented Sep 20, 2024

nodejs-github-bot commented Sep 20, 2024

RedYetiDev commented Sep 20, 2024

aduh95 commented Sep 20, 2024

codecov bot commented Sep 20, 2024 • edited Loading

Codecov Report

benjamingr left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Sep 21, 2024 • edited by jasnell Loading

RedYetiDev commented Sep 21, 2024 • edited Loading

marco-ippolito commented Sep 23, 2024

RedYetiDev commented Sep 23, 2024

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Sep 23, 2024

process: remove `process.assert` #55035

process: remove `process.assert` #55035

codecov bot commented Sep 20, 2024 •

edited

Loading

nodejs-github-bot commented Sep 21, 2024 •

edited by jasnell

Loading

RedYetiDev commented Sep 21, 2024 •

edited

Loading