tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo #52627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
RedYetiDev
added
the
semver-minor
RedYetiDev
force-pushed
the
fix-tls-error-typo
branch
from
9799502
to
a52db4a
Compare
panva
added
semver-major
|
Changing existing error code values is always semver-major. |
Good to know! Thanks! |
panva
reviewed
Apr 22, 2024
|
Ack! I totally forgot to update the commit message. I'll do it in a few hours... |
RedYetiDev
force-pushed
the
fix-tls-error-typo
branch
from
37c098a
to
32032a1
Compare
panva
changed the title
panva
approved these changes
Apr 29, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mertcanaltin
approved these changes
Apr 30, 2024
tniessen
approved these changes
May 13, 2024
panva
approved these changes
May 29, 2024
|
Is this good to land (semver-major)? |
|
No objections - |
daeyeon
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52627 ✔ Done loading data for nodejs/node/pull/52627 ----------------------------------- PR info ------------------------------------ Title tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (#52627) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch RedYetiDev:fix-tls-error-typo -> nodejs:main Labels crypto, c++, semver-major, author ready, needs-ci Commits 1 - tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo Committers 1 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/52627 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52627 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 21 Apr 2024 19:52:53 GMT ✔ Approvals: 2 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/52627#pullrequestreview-2084824754 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/52627#pullrequestreview-2053861852 ✘ semver-major requires at least 2 TSC approvals ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-30T08:25:52Z: https://ci.nodejs.org/job/node-test-pull-request/58815/ - Querying data for job/node-test-pull-request/58815/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10525204300 |
RedYetiDev
removed
the
commit-queue-failed
|
@jasnell approved the PR, so it has enough approvals to land :-) |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
PR is currently blocked from landing by unreliable CI. |
Is that still the case? Except for the skipped MacOS runner, the CI on this LGTM |
|
PR should be rebased with a fresh CI run after. |
Co-Authored-By: Fabian Iwand <mootari@users.noreply.github.com>
panva
force-pushed
the
fix-tls-error-typo
branch
from
32032a1
to
ce040bd
Compare
panva
approved these changes
Sep 11, 2024
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52627 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 651 651
Lines 183386 183386
Branches 35800 35795 -5
=======================================
+ Hits 161504 161506 +2
+ Misses 15159 15157 -2
Partials 6723 6723
|
|
@nodejs/tsc per nodejs/Release#1034 |
richardlau
approved these changes
Sep 19, 2024
marco-ippolito
approved these changes
Sep 19, 2024
RafaelGSS
approved these changes
Sep 20, 2024
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f666a1b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #23188
Fixes: #52448